feat: Adding matching WU Context Menu functionality from the ECL IDE #364
Conversation
dehilsterlexis
force-pushed
the
WU_CONTEXT_MENU
branch
6 times, most recently
from
85482db to
696282b
Compare
|
@GordonSmith I need to put a limit check still on the CSV files. I will let you know when that is done. |
dehilsterlexis
force-pushed
the
WU_CONTEXT_MENU
branch
from
696282b to
8654f0b
Compare
|
@GordonSmith I fixed my sequential problem so this is ready for full review. |
dehilsterlexis
force-pushed
the
WU_CONTEXT_MENU
branch
from
8654f0b to
4d81c61
Compare
dehilsterlexis
force-pushed
the
WU_CONTEXT_MENU
branch
2 times, most recently
from
14879b5 to
0745382
Compare
|
@GordonSmith for review |
| { | ||
| "command": "hpccPlatform.openResults", | ||
| "category": "ECL", | ||
| "title": "%Open Results%" |
There was a problem hiding this comment.
Shoud this be "Browse Results"? IOW does it open in an external browser, or does it activate the results view in vscode?
There was a problem hiding this comment.
Open Results opens the results locally, no using ECL Watch. This is the same for the ECL IDE.
There was a problem hiding this comment.
Can you open a new ticket to "Browse WU Details" for WUs
There was a problem hiding this comment.
Do you mean "issue" or "jira" for the ECL IDE, or both?
dehilsterlexis
force-pushed
the
WU_CONTEXT_MENU
branch
2 times, most recently
from
f2121be to
7d6e0e8
Compare
|
@GordonSmith for review |
src/ecl/saveData.ts
Outdated
| return maxRowsFound; | ||
| const rows = await vscode.window.showInputBox({ | ||
| title: localize("Max number of rows to save"), | ||
| prompt: `${maxRowsFound} ${localize("rows found. Please choose")} ${this._maxRows} ${localize("or less")}`, |
There was a problem hiding this comment.
For future ref: Another option is to have a single string "MMM rows found. Please choose NNN or less" and swap out the MMM and NNN with numbers (can be easier for the translators).
Signed-off-by: David de Hilster <[email protected]>
dehilsterlexis
force-pushed
the
WU_CONTEXT_MENU
branch
from
7d6e0e8 to
9da291a
Compare
|
@GordonSmith for review |
Fixes #363