Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC4J-673 Fix Poms and directory structure to include spark-hpcc as a module of the hpcc4j project #780

Merged
merged 3 commits into from
Dec 19, 2024
Merged

HPCC4J-673 Fix Poms and directory structure to include spark-hpcc as a module of the hpcc4j project #780

merged 3 commits into from
Dec 19, 2024

Conversation

Michael-Gardner
Copy link
Contributor

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

rpastrana
rpastrana requested changes Dec 17, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
spark-hpcc/README.md Outdated Show resolved Hide resolved
spark-hpcc/README.md Show resolved Hide resolved
spark-hpcc/README.md Outdated Show resolved Hide resolved
spark-hpcc/src/main/javadoc/overview.html Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
rpastrana
rpastrana approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Michael-Gardner just one minor question regarding the scala related version variables at the top level pom. Other than that it looks good to go. please merge

pom.xml Outdated
@@ -65,6 +67,8 @@
<opentelemetry.bom.version>1.38.0</opentelemetry.bom.version>
<opentelemetry.semconv.version>1.25.0-alpha</opentelemetry.semconv.version>
<opentelemetry.instrumentation.annotations.version>2.6.0</opentelemetry.instrumentation.annotations.version>
<scala.binary.version>2.11</scala.binary.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think scala is spark-hpcc specific

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved both of those scala references back over to the spark-hpcc Pom. Merging.

jpmcmu
jpmcmu approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@jpmcmu jpmcmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Michael-Gardner looks good to me

@jpmcmu
Copy link
Contributor

jpmcmu commented Dec 18, 2024

@Michael-Gardner It seems like the Javadoc workflow are running the Spark tests. I think this because we have a profile for remote tests on the HPCC4j side but not the Spark side. It seems like we can simply add a -Dmaven.test.skip=True to the maven command in the workflows/javadocTest.yml

@Michael-Gardner Michael-Gardner merged commit bda0844 into hpcc-systems:master Dec 19, 2024
2 of 5 checks passed
@github-actions GitHub Actions
Copy link

Jirabot Action Result:
Added fix version: 9.10.0
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmcmu jpmcmu jpmcmu approved these changes

@rpastrana rpastrana rpastrana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Michael-Gardner @jpmcmu @rpastrana