Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC4J-666 Update up/download plugin to v4 #776

Merged
merged 1 commit into from
Dec 2, 2024
Merged

HPCC4J-666 Update up/download plugin to v4 #776

merged 1 commit into from
Dec 2, 2024

Conversation

rpastrana
Copy link
Member

@rpastrana rpastrana commented Dec 2, 2024 •
edited
Loading

  • Updates deprecated up/download github action plugin

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-666

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

@rpastrana rpastrana requested a review from jpmcmu December 2, 2024 18:00
@rpastrana
Copy link
Member Author

@jpmcmu please review

jpmcmu
jpmcmu approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@jpmcmu jpmcmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpastrana looks good

@rpastrana
HPCC4J-666 Update github action plugins
d18317f 
- Updates deprecated up/download github action plugin to v4
- Updates deprecated codeql github action plugin to v3
- Updates deprecated cache github action plugin to v3

Signed-off-by: Rodrigo Pastrana <[email protected]>
@rpastrana rpastrana force-pushed the HPCC4J-666-GithubActionDownloadPluginVerUpdate branch from fe63d8a to d18317f Compare December 2, 2024 18:34
@rpastrana rpastrana merged commit 7202308 into hpcc-systems:master Dec 2, 2024
3 of 5 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Jirabot Action Result:
Added fix version: 9.10.0
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmcmu jpmcmu jpmcmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpastrana @jpmcmu