Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC4J-646 RowServiceInputStream set isTLK when reading a TLK #759

Merged
merged 1 commit into from
Sep 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2019,6 +2019,11 @@ private String makeNodeObject()
sb.append(getFilePartCopy() + 1);
sb.append("\", \n");

if (this.dataPart.isTLK())
{
sb.append("\"isTlk\" : \"true\",\n");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be worthwhile annotating current span w/ this flag

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per offline comment, further span annotations will be handled in dedicated pr

}

// Do not apply filters and limits when inFetchingMode
if (inFetchingMode == false)
{
Expand Down
Loading