Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC4J-614 WsStore IPT invalid character tests #725

Merged
merged 1 commit into from
Jul 22, 2024
Merged

HPCC4J-614 WsStore IPT invalid character tests #725

merged 1 commit into from
Jul 22, 2024

Conversation

rpastrana
Copy link
Member

@rpastrana rpastrana commented Jul 22, 2024 •
edited
Loading

  • Adds new WsStore tests based on values which include IPT attribute delimiters
  • Fixes issue noticed in wsstoreclient
  • Adds ability to test encod-able username
  • Adds fetch encoded key test
  • Adds fetch invalid key test

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@rpastrana
HPCC4J-614 WsStore IPT invalid character tests
ce6b7cf 
- Adds new WsStore tests based on values which include IPT attribute delimiters
- Fixes issue noticed in wsstoreclient
- Adds ability to test encod-able username
- Adds fetch encoded key test
- Adds fetch invalid key test

Signed-off-by: Rodrigo Pastrana <[email protected]>
@rpastrana rpastrana requested a review from jpmcmu July 22, 2024 14:43
@rpastrana
Copy link
Member Author

@jpmcmu this is a rebase of #717 to 9.2.x
Please approve so we can merge

@rpastrana rpastrana mentioned this pull request Jul 22, 2024
Closed
22 tasks
jpmcmu
jpmcmu approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@jpmcmu jpmcmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpastrana looks good

@rpastrana rpastrana merged commit b3d80dd into hpcc-systems:candidate-9.2.x Jul 22, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmcmu jpmcmu jpmcmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpastrana @jpmcmu