Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC4J-608 Merge fix version failure #715

Merged
merged 1 commit into from
Jun 11, 2024
Merged

HPCC4J-608 Merge fix version failure #715

merged 1 commit into from
Jun 11, 2024

Conversation

jpmcmu
Copy link
Contributor

@jpmcmu jpmcmu commented Jun 7, 2024

  • Fixed jirabot merge add fix version code
  • Updated transition logic to be less brittle

Signed-off-by: James McMullan [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@jpmcmu jpmcmu requested a review from rpastrana June 7, 2024 19:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-608

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

rpastrana
rpastrana reviewed Jun 10, 2024
View reviewed changes
.github/workflows/JirabotMerge.yml Outdated

print("Attempting to close out Jira issue: %s %s %s" % (title, user, comments_url))
result = ''
issuem = re.search("(HPCC4J|JAPI)-[0-9]+", title)
issuem = re.search("(" + project_name + ")-[0-9]+", title)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this search case sensitive?
I can't tell if project_name has been upper/lower cased

rpastrana
rpastrana approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu seems fine. Left a minor comment.
But also, what is the expected behavior if the transition flow fails?

@jpmcmu
Copy link
Contributor Author

jpmcmu commented Jun 11, 2024

@rpastrana Implemented code review changes, and added code to add comments to the PR on results of the Jirabot action as well.

rpastrana
rpastrana approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu looks good

@jpmcmu
HPCC4J-608 Merge fix version failure
d38b690 
- Fixed jirabot merge add fix version code
- Updated transition logic to be less brittle

Signed-off-by: James McMullan [email protected]
@rpastrana rpastrana merged commit 3603b8e into hpcc-systems:master Jun 11, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpastrana rpastrana rpastrana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmcmu @rpastrana