HPCC4J-599 Halt all JUnits on init failure

[jpmcmu]

• Updated init logic in BaseRemoteTest to automatically fail tests if init fails

Signed-off-by: James McMullan [email protected]

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

• I have created a corresponding JIRA ticket for this submission
• My code follows the code style of this project.
  • I have applied the Eclipse code-format template provided.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
• The change has been fully tested:
  • This change does not cause any existing JUnits to fail.
  • I have include JUnit coverage to test this change
  • I have performed system test and covered possible regressions and side effects.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Premature optimization
  • This change fixes the problem, not just the symptom

Testing:

[github-actions]

Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-599

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

[rpastrana]

not a big deal, but I wonder if the initialized bool is necessary. It seems initializationException can be used to determine if init succeeded/failed.

[rpastrana]

@jpmcmu seems fine. Left a comment regarding a redundant variable. Also, can we add a test case to confirm/validate this functionality?

[rpastrana]

@jpmcmu seems fine, can you provide me a link to a sample run?

[jpmcmu]

@rpastrana squashed. Here is the output from the test that shows what a failure would look like in the logs:

Error: Failures:
Error: BaseRemoteInitTest.initTest:36 Error initializing test suite: Could not acquire wsclient object: null
[INFO]
Error: Tests run: 57, Failures: 1, Errors: 0, Skipped: 17