Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC4J-567 Adapt WsFileIOClient to latest ESP behavior #703

Merged
merged 1 commit into from
Apr 4, 2024
Merged

HPCC4J-567 Adapt WsFileIOClient to latest ESP behavior #703

merged 1 commit into from
Apr 4, 2024

Conversation

rpastrana
Copy link
Member

@rpastrana rpastrana commented Apr 2, 2024 •
edited
Loading

  • Adds new methods with exposed LZ Address
  • Provides LZ in non-containerized junits
  • Changes default LZ name from localhost to mylandingzone

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@rpastrana rpastrana requested a review from jpmcmu April 2, 2024 19:23
@rpastrana
Copy link
Member Author

@jpmcmu please review

@rpastrana rpastrana force-pushed the HPCC4J-567-WsFileIOJumit branch from 3a6396a to f509118 Compare April 2, 2024 20:44
@rpastrana
HPCC4J-567 Adapt WsFileIOClient to latest ESP behavior
8dbcfb6 
- Adds new methods with exposed LZ Address
- Provides LZ in non-containerized junits
- Changes default LZ name from localhost to mylandingzone

Signed-off-by: Rodrigo Pastrana <[email protected]>
@rpastrana rpastrana force-pushed the HPCC4J-567-WsFileIOJumit branch from f509118 to 8dbcfb6 Compare April 2, 2024 20:48
jpmcmu
jpmcmu approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@jpmcmu jpmcmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpastrana looks good to me

@rpastrana rpastrana merged commit cbbe7b4 into hpcc-systems:candidate-9.4.x Apr 4, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmcmu jpmcmu jpmcmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpastrana @jpmcmu