-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JAPI-573 Add in default support for set of #697
JAPI-573 Add in default support for set of #697
Conversation
I was also able to rework the antlr to support all of the following RECORD |
Test failures seem unrelated to proposed changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jchambers-ln it looks fine, but would like @drealeed and @jpmcmu to chime in as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jchambers-ln looks fine, minor comment on code format & commented out code
val = val.substring(0, val.length() - 2); | ||
} | ||
} | ||
//val = val.replaceFirst("(\[')", ""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: formatting differs here, and might want to remove these commented out lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed commented code
https://track.hpccsystems.com/browse/JAPI-573
Type of change:
Checklist:
Testing:
Basic unit test added to hpcc4j, additional testing added to DSP to validate it works with the requirements leading to it being added.