Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAPI-573 Add in default support for set of #697

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

jchambers-ln
Copy link
Member

https://track.hpccsystems.com/browse/JAPI-573

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

Basic unit test added to hpcc4j, additional testing added to DSP to validate it works with the requirements leading to it being added.

@jchambers-ln
Copy link
Member Author

I was also able to rework the antlr to support all of the following

RECORD
STRING1 test;
SET OF UTF8 fieldAllset {DEFAULT (ALL)};
SET OF UTF8 field2set {DEFAULT (['test1','test2'])};
SET OF UTF8 field3set {DEFAULT ([''])};
SET OF UTF8 field4set {DEFAULT (['test'])};
STRING2 test;
END;

@rpastrana rpastrana requested review from drealeed and jpmcmu March 27, 2024 13:21
@rpastrana
Copy link
Member

Test failures seem unrelated to proposed changes.

Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jchambers-ln it looks fine, but would like @drealeed and @jpmcmu to chime in as well

Copy link
Collaborator

@drealeed drealeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@jpmcmu jpmcmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jchambers-ln looks fine, minor comment on code format & commented out code

val = val.substring(0, val.length() - 2);
}
}
//val = val.replaceFirst("(\[')", "");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: formatting differs here, and might want to remove these commented out lines.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed commented code

@rpastrana rpastrana merged commit 5750c77 into hpcc-systems:candidate-9.4.x Mar 28, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants