Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC4J-579 prefetch thread hot loop fix #685

Merged
merged 1 commit into from
Feb 28, 2024
Merged

HPCC4J-579 prefetch thread hot loop fix #685

merged 1 commit into from
Feb 28, 2024

Conversation

jpmcmu
Copy link
Contributor

@jpmcmu jpmcmu commented Feb 23, 2024

  • Changed prefetch thread behavior to short sleep after each request
  • Added short sleep on main thread if blocked by prefetch thread for more than 10us

Signed-off-by: James McMullan [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@jpmcmu jpmcmu requested a review from rpastrana February 23, 2024 00:07
@jpmcmu jpmcmu changed the title WIP: HPCC4J-579 prefetch thread hot loop fix HPCC4J-579 prefetch thread hot loop fix Feb 23, 2024
rpastrana
rpastrana requested changes Feb 26, 2024
View reviewed changes
dfsclient/src/main/java/org/hpccsystems/dfs/client/RowServiceInputStream.java Outdated
}

inputStream.prefetchData();
catch(Exception e){}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catch and ignore only the exception types we know we should ignore

@jpmcmu
HPCC4J-579 prefetch thread hot loop fix
3818c6a 
- Changed prefetch thread behavior to short sleep after each request
- Added short sleep on main thread if blocked by prefetch thread for more than 10us

Signed-off-by: James McMullan [email protected]
@jpmcmu jpmcmu changed the base branch from candidate-9.4.x to candidate-9.2.x February 28, 2024 01:44
@jpmcmu
Copy link
Contributor Author

jpmcmu commented Feb 28, 2024

@rpastrana back ported to 9.2.x, implemented code review changes and squashed

@jpmcmu jpmcmu requested a review from rpastrana February 28, 2024 01:45
rpastrana
rpastrana reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu looks fine. I didn't see a comment on why 9.2.x was targeted instead on 9.0.x

rpastrana
rpastrana approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not targeting 9.0.x due to unrelated test issues preventing full acceptance tests

@rpastrana rpastrana merged commit 54c31b6 into hpcc-systems:candidate-9.2.x Feb 28, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpastrana rpastrana rpastrana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmcmu @rpastrana