Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC4J-555 Provide Test Jar #661

Merged
merged 1 commit into from
Dec 5, 2023
Merged

HPCC4J-555 Provide Test Jar #661

merged 1 commit into from
Dec 5, 2023

Conversation

jpmcmu
Copy link
Contributor

@jpmcmu jpmcmu commented Nov 27, 2023

  • Moved BaseRemoteTests into testing dir
  • Added TestResultNotifier
  • Updated POMs to generate test-jar

Signed-off-by: James McMullan [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@jpmcmu jpmcmu changed the title WIP: HPCC4J-555 Provide Test Jar HPCC4J-555 Provide Test Jar Nov 29, 2023
@jpmcmu
Copy link
Contributor Author

jpmcmu commented Nov 29, 2023

@rpastrana Go ahead and review. Still working on how to fix the javadoc issue though

@jpmcmu jpmcmu requested a review from rpastrana December 5, 2023 14:16
@jpmcmu
Copy link
Contributor Author

jpmcmu commented Dec 5, 2023

@rpastrana Implemented code review changes & squashed

rpastrana
rpastrana approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@rpastrana rpastrana changed the base branch from candidate-9.4.x to candidate-9.0.x December 5, 2023 16:10
@rpastrana rpastrana changed the base branch from candidate-9.0.x to candidate-9.4.x December 5, 2023 16:11
@jpmcmu jpmcmu changed the base branch from candidate-9.4.x to candidate-9.0.x December 5, 2023 17:38
@jpmcmu
HPCC4J-555 Provide Test jar
5df1ca5 
- Moved BaseRemoteTests into testing dir
- Added TestResultNotifier to record test failures
- Updated POMs to use and generate test-jar

Signed-off-by: James McMullan [email protected]
@jpmcmu
Copy link
Contributor Author

jpmcmu commented Dec 5, 2023

@rpastrana retargeted to 9.0x

@rpastrana rpastrana merged commit d78e7fe into hpcc-systems:candidate-9.0.x Dec 5, 2023
6 checks passed
rpastrana pushed a commit to rpastrana/HPCC4J that referenced this pull request Dec 7, 2023
HPCC4J-555 Provide Test jar (hpcc-systems#661)
ab1e783 
- Moved BaseRemoteTests into testing dir
- Added TestResultNotifier to record test failures
- Updated POMs to use and generate test-jar

Signed-off-by: James McMullan [email protected]

Signed-off-by: James McMullan [email protected]
# Conflicts:
#	wsclient/src/test/java/org/hpccsystems/ws/client/BaseRemoteTest.java
#	wsclient/src/test/java/org/hpccsystems/ws/client/WsClientTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpastrana rpastrana rpastrana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmcmu @rpastrana