Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-33113 Ensure empty compressed part size is correct #19353

Merged
merged 1 commit into from
Dec 11, 2024
Merged

HPCC-33113 Ensure empty compressed part size is correct #19353

merged 1 commit into from
Dec 11, 2024

Conversation

jakesmith
Copy link
Member

@jakesmith jakesmith commented Dec 11, 2024 •
edited
Loading

When writing a logical file that is wider than Thor with, Thor pads the file at publish time with empty parts. If compressed it creates an empty compressed file, which will typically be non-zero in size (e.g. contains compressed header). The logical file part meta data did not relect this correct physical size.
Consequently, as a result of the check added in HPCC-33064, reading these files was provoking this error check.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33113

Jirabot Action Result:
Assigning user: [email protected]
Workflow Transition To: Merge Pending
Updated PR

@jakesmith
HPCC-33113 Ensure empty compressed part size is correct
b6aaaa1 
When writing a logical file that is wider than Thor with,
Thor pads the file at publish time with empty parts.
If compressed it creates an empty compressed file, which
will typically be non-zero in size (e.g. contains compressed
header). The logical file part meta data did not relect this
correct physical size.
Consequently, as a result of the check added in HPCC-33064,
reading these files was provoking this error check.

Signed-off-by: Jake Smith <[email protected]>
@jakesmith jakesmith force-pushed the HPCC-33113-compressed-file-size-width branch from 7ba4780 to b6aaaa1 Compare December 11, 2024 16:37
@ghalliday ghalliday closed this Dec 11, 2024
@ghalliday ghalliday reopened this Dec 11, 2024
@ghalliday ghalliday changed the base branch from candidate-9.8.x to candidate-9.2.x December 11, 2024 16:37
@ghalliday ghalliday closed this Dec 11, 2024
@ghalliday ghalliday reopened this Dec 11, 2024
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33113

Jirabot Action Result:
Workflow Transition To: Merge Pending

1 similar comment
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33113

Jirabot Action Result:
Workflow Transition To: Merge Pending

@ghalliday ghalliday merged commit 73dc674 into hpcc-systems:candidate-9.2.x Dec 11, 2024
153 of 156 checks passed
@github-actions GitHub Actions
Copy link

Jirabot Action Result:
Added fix version: 9.2.146
Added fix version: 9.4.120
Added fix version: 9.6.72
Added fix version: 9.8.46
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakesmith @ghalliday