Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-32445 Remove bad links from PT_BR Docs #19346

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

g-pan
Copy link
Member

@g-pan g-pan commented Dec 9, 2024

@vfumene should be primary reviewer for this JIRA
unable to designate https://github.com/vfumene
he reviewed offline : https://github.com/g-pan/github-action-dev-build/actions/runs/12241339087
@vfumene please approve in the comments below

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

successfully tested: https://github.com/g-pan/github-action-dev-build/actions/runs/12241339087

Copy link

github-actions bot commented Dec 9, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32445

Jirabot Action Result:
Changing assignee from: [email protected] to: [email protected]
Workflow Transition To: Merge Pending
Updated PR

@vfumene
Copy link
Contributor

vfumene commented Dec 9, 2024

Hi @g-pan. Approved.
Thanks

@@ -1020,12 +1033,22 @@ thor: []
</sect4>
</sect3>

<sect3 id="Compile_Costs">
Copy link
Contributor

@Michael-Gardner Michael-Gardner Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be sect3?

Edit: apparently github markup doesn't like /</> in comments

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is ok as is

@Michael-Gardner Michael-Gardner self-requested a review December 10, 2024 14:32
@g-pan g-pan removed the request for review from JamesDeFabia December 10, 2024 18:18
@ghalliday ghalliday merged commit c120cbc into hpcc-systems:candidate-9.8.x Dec 11, 2024
52 of 53 checks passed
Copy link

Jirabot Action Result:
Added fix version: 9.8.46
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants