Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-33066: Add basic ECL Watch UI tests #19337

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Dec 4, 2024

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Copy link

github-actions bot commented Dec 4, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33066

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

@GordonSmith GordonSmith force-pushed the HPCC-33066-PLAYWRIGHT_TESTS branch from d0e69ab to 29b70fc Compare December 4, 2024 12:30
@AttilaVamos
Copy link
Contributor

AttilaVamos commented Dec 5, 2024

@GordonSmith under CentOS 7 (based on this is 9.2.x related) with npm 8.1.2 the build of this PR is stalling on this command

npm run test

more precisely, on the

npm exec playwright test

How long should it take to finish?

@GordonSmith GordonSmith merged commit ed88cd9 into hpcc-systems:candidate-9.2.x Dec 12, 2024
49 of 51 checks passed
@GordonSmith GordonSmith deleted the HPCC-33066-PLAYWRIGHT_TESTS branch December 12, 2024 16:30
Copy link

Jirabot Action Result:
Added fix version: 9.2.146
Added fix version: 9.4.120
Added fix version: 9.6.72
Added fix version: 9.8.46
Workflow Transition: 'Resolve issue'

@GordonSmith
Copy link
Member Author

@GordonSmith under CentOS 7 (based on this is 9.2.x related) with npm 8.1.2 the build of this PR is stalling on this command

npm run test

more precisely, on the

npm exec playwright test

How long should it take to finish?

Can you:

  1. Bump the NodeJS version in that VM to version 22
  2. Pre-install the test runtimes with npx playwright install --with-deps
  3. Ensure you have set the environment variable CI to true (this will help your environment behave more like the GH environments)

Also the new tests will need egress to play.hpccsystems.com.

If you want to skip the test and have the same behaviour as before, you can change npm run test to npm run lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants