-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-31872 Allow alternate certificate domains #19315
Merged
ghalliday
merged 1 commit into
hpcc-systems:candidate-9.8.x
from
asselitx:certificate-domains-hpcc-31872
Dec 17, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1894,6 +1894,7 @@ args: | |
{{- end -}} | ||
{{- end -}} | ||
{{- $_ := set $local "dnsNames" (uniq $local.dnsNames ) -}} | ||
{{- $_ := set $local "allDomains" (prepend (default list $issuer.alternativeDomains) $domain ) -}} | ||
{{- if $externalCert -}} | ||
{{- $_ := set $local "commonName" (mustFirst $local.dnsNames ) -}} | ||
{{- else -}} | ||
|
@@ -1929,7 +1930,9 @@ spec: | |
{{- end }} | ||
dnsNames: | ||
{{- range $dnsName := $local.dnsNames }} | ||
- {{ (printf "%s.%s" $dnsName $domain) | quote }} | ||
{{- range $altDomain := $local.allDomains }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If I were being super picky I would say the variable name "altDomain" is not right. $local.allDomains contains the primary domain and the alts. But hardly matters. |
||
- {{ (printf "%s.%s" $dnsName $altDomain) | quote }} | ||
{{- end }} | ||
{{- end }} | ||
{{- if $spiffe }} | ||
uris: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,102 @@ | ||
global: | ||
privileged: true | ||
egress: | ||
restricted: false | ||
certificates: | ||
issuers: | ||
remote: | ||
name: hpcc-remote-issuer | ||
domain: hpcc1 | ||
alternativeDomains: | ||
- foo.hpcc1 | ||
- bar.hpcc1 | ||
## set enabled to true if adding remoteClients for any components | ||
enabled: true | ||
## kind can be changed to ClusterIssue to refer to a ClusterIssuer. https://cert-manager.io/docs/reference/api-docs/#cert-manager.io/v1.ClusterIssuer | ||
kind: Issuer | ||
spiffe: false | ||
## do not define spec (set spec: null), to reference an Issuer resource that already exists in the cluster | ||
## change spec if you'd like to change how certificates get issued... see ## https://cert-manager.io/docs/configuration/#supported-issuer-types | ||
## for information on what spec should contain. | ||
spec: | ||
ca: | ||
secretName: hpcc-local-issuer-key-pair # real config would use hpcc-remote, but examples have hpcc-local instructions | ||
|
||
signing: # intended to be used for signing/verification purposes only, e.g. by dafilesrv | ||
name: hpcc-signing-issuer | ||
## kind can be changed to ClusterIssue to refer to a ClusterIssuer. https://cert-manager.io/docs/reference/api-docs/#cert-manager.io/v1.ClusterIssuer | ||
kind: Issuer | ||
## do not define spec (set spec: null), to reference an Issuer resource that already exists in the cluster | ||
## change spec if you'd like to change how certificates get issued... see ## https://cert-manager.io/docs/configuration/#supported-issuer-types | ||
## for information on what spec should contain. | ||
spec: | ||
ca: | ||
secretName: hpcc-signing-issuer-key-pair | ||
|
||
thor: null | ||
eclagent: null | ||
eclscheduler: null | ||
dafilesrv: null | ||
dfuserver: null | ||
|
||
sasha: | ||
disabled: true | ||
wu-archiver: | ||
disabled: true | ||
dfuwu-archiver: | ||
disabled: true | ||
dfurecovery-archiver: | ||
disabled: true | ||
file-expiry: | ||
disabled: true | ||
|
||
esp: | ||
- name: eclwatch | ||
application: eclwatch | ||
auth: none | ||
replicas: 1 | ||
service: | ||
port: 8888 | ||
servicePort: 18010 | ||
visibility: local | ||
- name: eclqueries | ||
application: eclqueries | ||
auth: none | ||
replicas: 1 | ||
service: | ||
visibility: local | ||
servicePort: 18002 | ||
- name: eclservices | ||
application: eclservices | ||
auth: none | ||
replicas: 1 | ||
service: | ||
servicePort: 8010 | ||
visibility: cluster | ||
|
||
roxie: | ||
- name: roxie1 | ||
disabled: false | ||
prefix: roxie1 | ||
services: | ||
- name: roxie1 | ||
servicePort: 19876 | ||
listenQueue: 200 | ||
numThreads: 30 | ||
visibility: local | ||
trustClients: | ||
- commonName: roxie2.hpcc2 | ||
- name: roxie1backup | ||
servicePort: 19877 | ||
listenQueue: 200 | ||
numThreads: 30 | ||
visibility: local | ||
trustClients: | ||
- commonName: roxie2.hpcc2 | ||
replicas: 1 | ||
numChannels: 1 | ||
serverReplicas: 0 | ||
localAgent: false | ||
traceLevel: 1 | ||
topoServer: | ||
replicas: 1 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: This the default operator is more normally written as
($issuer.alternativeDomains | default list)
(I had to read some documentation to check the semantics...)