Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-32683 Fix issues with postmortem and container death #19296

Merged
merged 1 commit into from
Dec 9, 2024
Merged

HPCC-32683 Fix issues with postmortem and container death #19296

merged 1 commit into from
Dec 9, 2024

Conversation

jakesmith
Copy link
Member

@jakesmith jakesmith commented Nov 13, 2024 •
edited
Loading

helm changes:

  • Consistently generate command via addCommandAndLifecycle, and collect added container information in lifeCycleCtx based on containers added to lifeCycleCtx
  • Add terminationGracePeriodSeconds option
  • Mount ephemeral directories in distinct subPaths.
  • Fix issues with postmortem's from different containers overwriting one another
  • Add addPostRunContainer to generate postrun container, to monitor running containers.

script changes:

  • add container_watch.sh for postrun pod.
  • move all options handling into check_executes.sh

code changes:

  • code grace time into k8s job file into, so that postjob clearup can also use
  • Clear wuid file (prevents spurious error association)

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32683

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

@jakesmith jakesmith force-pushed the HPCC-32683-postrun branch 2 times, most recently from 53d82b9 to 99b7b5c Compare November 14, 2024 11:05
@jakesmith jakesmith requested a review from ghalliday November 14, 2024 11:29
@ghalliday ghalliday requested a review from mckellyln November 15, 2024 12:58
@ghalliday
Copy link
Member

Mark I would value you reviewing this change as well.

ghalliday
ghalliday reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell. I didn't see any issues.

helm/hpcc/templates/thor.yaml Outdated
@@ -234,31 +241,36 @@ data:
spec:
{{- include "hpcc.placementsByJobTargetType" (dict "root" .root "job" $thorWorkerJobName "target" .me.name "type" "thor") | indent 10 }}
serviceAccountName: hpcc-default
terminationGracePeriodSeconds: {{ .terminationGracePeriodSeconds | default 60 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

60 rather than 600 used elsewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, will change it to 600.

initfiles/bin/container_watch.sh
@@ -0,0 +1,158 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be valuable to have a comment at the head of each of these bash scripts to describe what it is doing, and how it fits into the overall postmortem process.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added comment blocks.

@jakesmith
Copy link
Member Author

@ghalliday - see 2nd commit.

@jakesmith jakesmith requested a review from ghalliday December 3, 2024 20:05
mckellyln
mckellyln previously requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@mckellyln mckellyln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Approved.
(But I am not an expert in this area)

mckellyln
mckellyln approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@mckellyln mckellyln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Approved.
(But I am not an expert in the area)

@jakesmith
HPCC-32683 Fix issues with postmortem and container death
2e1e047 
helm changes:
- Consistently generate command via addCommandAndLifecycle,
and collect added container information in lifeCycleCtx
based on containers added to lifeCycleCtx
- Add terminationGracePeriodSeconds option
- Mount ephemeral directories in distinct subPaths.
- Fix issues with postmortem's from different containers
overwriting one another
- Add addPostRunContainer to generate postrun container,
to monitor running containers.

script changes:
- add container_watch.sh for postrun pod.
- move all options handling into check_executes.sh

code changes:
- code grace time into k8s job file into, so that postjob
clearup can also use
- Clear wuid file (prevents spurious error association)

Signed-off-by: Jake Smith <[email protected]>
@jakesmith
Copy link
Member Author

@ghalliday - now squashed.

@ghalliday ghalliday merged commit 6ffae6c into hpcc-systems:master Dec 9, 2024
47 of 50 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

Jirabot Action Result:
Added fix version: 9.10.0
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mckellyln mckellyln mckellyln approved these changes

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakesmith @ghalliday @mckellyln