-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-32898 Bump actions/upload-artifact version #19245
base: candidate-9.4.x
Are you sure you want to change the base?
HPCC-32898 Bump actions/upload-artifact version #19245
Conversation
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32898 Jirabot Action Result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you need to bump the download-artifact version as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because I don't think this is going to be an issue we hit. But I want to make sure you and I are both aware of it.
In v4 there is a behavior change where it doesn't overwrite automatically if the artifact name matches a previously uploaded artifact name. In our cases I think this could only be an issue for failure logs (more than 1 attempt to run). We might have to add overwrite: true
to those cases.
documentation of changes are here https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes
Signed-off-by: Gordon Smith <[email protected]>
2a633af
to
553d0eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems good.
Type of change:
Checklist:
Smoketest:
Testing: