HPCC-32690 Add CentOS 7 back into the 9.8.x releases

[GordonSmith]

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Cloud-compatibility
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Smoketest:

• Send notifications about my Pull Request position in Smoketest queue.
• Test my draft Pull Request.

Testing:

[GordonSmith]

@cloLN - FYI

[github-actions]

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32690

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

[ghalliday]

Looks reasonable. One change isn't clear

[ghalliday]

Not clear why this changed - it would be worth having a comment in the file to explain.

[Michael-Gardner]

Because we have to pin that label to the older 9.8.x build. If he kept the logic the same as everything else, we'd be reliant on a build with the current vcpkg_sha_short. And the current vcpkg version that we use for 9.8.x will fail for centos-7. This looks like a pretty clean way to sidestep that problem and 'pin' the centos-7 builds to our older hpcc-platform-9.8.x tag that we have pushed.

[GordonSmith]

Further - this pattern x == y && aaa || bbb can be read as x == y ? aaa : bbb

[ghalliday]

@GordonSmith I was looking for a comment in the yml file explaining why this needs to be special-cased, not what it was doing.

[Michael-Gardner]

@GordonSmith everything looks good. Pinning it to the hpccsystems/platform-build-base-centos-7:hpcc-platform-9.8.x is how I've been doing the manual builds as well.

[ghalliday]

@GordonSmith can you add a comment into the file to explain the change highlighted above.

[ghalliday]

@GordonSmith this is still waiting for a comment in the file.

[ghalliday]

This cannot be merged until the caching problem is resolved.

[ghalliday]

Closing because currently done on demand by hand. Reopen if there is a valid PR to introduce this.