Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-30850 JTrace accept credentials through secrets #18864

Open
wants to merge 1 commit into
base: candidate-9.6.x
Choose a base branch
from
Open

HPCC-30850 JTrace accept credentials through secrets #18864

wants to merge 1 commit into from

Conversation

rpastrana
Copy link
Member

@rpastrana rpastrana commented Jul 9, 2024 •
edited
Loading

  • Reads OTLPGRCP cert from secret
  • Provides sample configuration

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-30850

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

@rpastrana
Copy link
Member Author

WIP
Haven't been able to test. we might be trying to load a vault too early in the init process:

2024-07-09 16:24:26 00000000 OPR INF 2024-07-09 20:24:26.187 8 8 UNK "Exporter type: OTLP-GRPC"
2024-07-09 16:24:26 00000001 PRG INF 2024-07-09 20:24:26.193 8 8 UNK "JTrace: loading OTLP-GRPC 'cacert' from secret 'jtrace-credentials' category 'esp'"
2024-07-09 16:24:26 00000002 USR WRN 2024-07-09 20:24:26.194 8 8 UNK "vault: client cert not found, /opt/HPCCSystems/secrets/certificates/vaultclient/esp/tls.crt"
2024-07-09 16:24:26 00000003 USR WRN 2024-07-09 20:24:26.194 8 8 UNK "vault: client key not found, /opt/HPCCSystems/secrets/certificates/vaultclient/esp/tls.key"
2024-07-09 16:24:26 00000004 USR PRO 2024-07-09 20:24:26.194 8 8 UNK "vault url http://${env.VAULT_SERVICE_HOST}:${env.VAULT_SERVICE_PORT}/v1/secret/data/esp/${secret}"
2024-07-09 16:24:26 00000005 USR PRO 2024-07-09 20:24:26.194 8 8 UNK "Vault: httplib verify_server=true"
2024-07-09 16:24:26 00000006 USR PRO 2024-07-09 20:24:26.194 8 8 UNK "using kubernetes vault auth"
2024-07-09 16:24:26 00000007 PRG INF 2024-07-09 20:24:26.195 8 8 UNK "kubernetesLogin"
2024-07-09 16:24:26 00000008 OPR ERR 2024-07-09 20:24:26.199 8 8 UNK "HTTPLIB Error create_and_connect_socket failed"
2024-07-09 16:24:26 00000009 OPR ERR 2024-07-09 20:24:26.199 8 8 UNK "Retrying vault my-jtrace-credentials-vault kubernetes auth, communication error 2"
2024-07-09 16:24:27 0000000A OPR ERR 2024-07-09 20:24:27.200 8 8 UNK "HTTPLIB Error create_and_connect_socket failed"
2024-07-09 16:24:27 0000000B OPR ERR 2024-07-09 20:24:27.200 8 8 UNK "Retrying vault my-jtrace-credentials-vault kubernetes auth, communication error 2"
2024-07-09 16:24:28 0000000C OPR ERR 2024-07-09 20:24:28.200 8 8 UNK "HTTPLIB Error create_and_connect_socket failed"
2024-07-09 16:24:28 0000000D OPR ERR 2024-07-09 20:24:28.200 8 8 UNK "Retrying vault my-jtrace-credentials-vault kubernetes auth, communication error 2"
2024-07-09 16:24:29 0000000E OPR ERR 2024-07-09 20:24:29.201 8 8 UNK "HTTPLIB Error create_and_connect_socket failed"
2024-07-09 16:24:29 0000000F OPR ERR 2024-07-09 20:24:29.201 8 8 UNK "0: : Vault [my-jtrace-credentials-vault] kubernetes auth error login communication error 2"
2024-07-09 16:24:29 00000010 OPR ERR 2024-07-09 20:24:29.201 8 8 UNK "JTRACE: Unknown error creating Tracing exporter"
2024-07-09 16:24:29 00000011 PRG INF 2024-07-09 20:24:29.203 8 8 UNK "Using ESP configuration section [Software/EspProcess[1]]"

@rpastrana
HPCC-30850 JTrace accept credentials through secrets
8e15705 
- Reads OTLPGRCP cert from secret
- Provides sample configuration

Signed-off-by: Rodrigo Pastrana <[email protected]>
@rpastrana rpastrana force-pushed the HPCC-30850-JTraceUseSecret branch from b0431ce to 8e15705 Compare July 9, 2024 20:58
@ghalliday
Copy link
Member

@rpastrana did you mean to tag someone to review this?

@rpastrana rpastrana closed this Oct 18, 2024
@rpastrana rpastrana reopened this Oct 18, 2024
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-30850

Jirabot Action Result:
Workflow Transition To: Merge Pending

@rpastrana
Copy link
Member Author

@ghalliday this is still WIP, there was an issue with the secret access which we discussed but this was put in the backburner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpastrana @ghalliday