-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-32220 Remove unused ARGS #18862
HPCC-32220 Remove unused ARGS #18862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd advocate just deleting it.
If something is dependent on it, then it will affect it either way.
@AttilaVamos - are you using these nightly build images?
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32220 Jirabot Action Result: |
No, I am not using those images. |
17cf400
to
9b8e410
Compare
@jakesmith @ghalliday I have commented out what I think is the only place that is leaking tokens (which I am assuming are temp tokens for the GH Action)? |
9b8e410
to
04f84e3
Compare
Note: ARGS can be leaked to DockerHub by default Signed-off-by: Gordon Smith <[email protected]>
04f84e3
to
4376ee6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
@ghalliday - going to merge ahead of the nightly build and will do a test tag in the morning (assuming the nightly passed) |
Type of change:
Checklist:
Smoketest:
Testing: