Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-32220 Remove unused ARGS #18862

Merged

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Jul 9, 2024

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@GordonSmith GordonSmith requested a review from jakesmith July 9, 2024 16:00
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd advocate just deleting it.
If something is dependent on it, then it will affect it either way.

@AttilaVamos - are you using these nightly build images?

Copy link

github-actions bot commented Jul 9, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32220

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR
Assigning user: [email protected]

@AttilaVamos
Copy link
Contributor

I'd advocate just deleting it. If something is dependent on it, then it will affect it either way.

@AttilaVamos - are you using these nightly build images?

No, I am not using those images.

@GordonSmith GordonSmith force-pushed the HPCC-32220-DISABLE_NIGHTLYPUBLISH branch from 17cf400 to 9b8e410 Compare July 9, 2024 18:41
@GordonSmith GordonSmith requested a review from ghalliday July 9, 2024 18:43
@GordonSmith
Copy link
Member Author

@jakesmith @ghalliday I have commented out what I think is the only place that is leaking tokens (which I am assuming are temp tokens for the GH Action)?

@GordonSmith GordonSmith force-pushed the HPCC-32220-DISABLE_NIGHTLYPUBLISH branch from 9b8e410 to 04f84e3 Compare July 10, 2024 11:44
Note:  ARGS can be leaked to DockerHub by default

Signed-off-by: Gordon Smith <[email protected]>
@GordonSmith GordonSmith force-pushed the HPCC-32220-DISABLE_NIGHTLYPUBLISH branch from 04f84e3 to 4376ee6 Compare July 10, 2024 11:58
@GordonSmith GordonSmith changed the title HPCC-32220 Disable nightly-publish GH action HPCC-32220 Remove unused ARGS Jul 10, 2024
@GordonSmith GordonSmith requested a review from jakesmith July 10, 2024 12:01
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@GordonSmith
Copy link
Member Author

@ghalliday - going to merge ahead of the nightly build and will do a test tag in the morning (assuming the nightly passed)

@GordonSmith GordonSmith merged commit 1a7eedd into hpcc-systems:master Jul 10, 2024
49 of 50 checks passed
@GordonSmith GordonSmith deleted the HPCC-32220-DISABLE_NIGHTLYPUBLISH branch July 10, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants