Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-31971 SoapCall Span Enhancement #18847

Merged
merged 1 commit into from
Jul 16, 2024
Merged

HPCC-31971 SoapCall Span Enhancement #18847

merged 1 commit into from
Jul 16, 2024

Conversation

rpastrana
Copy link
Member

@rpastrana rpastrana commented Jul 2, 2024 •
edited
Loading

  • Renames socket write span
  • Provides target url and service in name
  • Provides target service and request type

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@rpastrana
HPCC-31971 SoapCall Span Enhancement
862e826 
- Renames socket write span
- Provides target url and service in name
- Provides target service and request type

Signed-off-by: Rodrigo Pastrana <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31971

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

@rpastrana rpastrana requested a review from ghalliday July 2, 2024 19:45
ghalliday
ghalliday reviewed Jul 10, 2024
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment/question.

common/thorhelper/thorsoapcall.cpp

Owned<IProperties> traceHeaders = ::getClientHeaders(socketOperationSpan);
StringBuffer spanName;
spanName.appendf("%s %s %s:%d", getWsCallTypeName(master->wscType), master->service.str(), url.host.str(), url.port);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you discussed this change with any of the potential users? Does it fit in with their conventions?

I would not expect the name to include the url or the port - since you ideally want to be able to aggregate over all instances.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed format change came about from a conversation between us. I've added a comment to the original jira asking for feedback, however I'm certain there are no current consumers, and no expected format.

https://hpccsystems.atlassian.net/browse/HPCC-31971?focusedCommentId=61883

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghalliday we've received at least one positive comment on proposed change in Jira.

@rpastrana rpastrana requested a review from ghalliday July 11, 2024 16:15
@ghalliday ghalliday merged commit bac371c into hpcc-systems:candidate-9.4.x Jul 16, 2024
26 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpastrana @ghalliday