Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-32118 Default to case-insensitive metric filtering #18829

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Jun 28, 2024

Introduced an option to toggle between case-sensitive and case-insensitive filtering

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg June 28, 2024 10:08
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32118

Jirabot Action Result:
Updated PR

Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith One question about a conditional statement. Looked good otherwise

esp/src/src-react/components/Metrics.tsx Outdated Show resolved Hide resolved
@GordonSmith GordonSmith force-pushed the HPCC-32118-METRICS_FILTER_CASE branch from f2bb9f5 to f765e83 Compare July 5, 2024 06:55
@GordonSmith GordonSmith requested a review from jeclrsg July 5, 2024 10:50
@GordonSmith GordonSmith force-pushed the HPCC-32118-METRICS_FILTER_CASE branch from f765e83 to 61b7d7f Compare July 5, 2024 10:51
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith Only one comment about how that match case button actually shows up in the UI. Seems pretty subtle as to what the status of it is

esp/src/src-react/components/Metrics.tsx Outdated Show resolved Hide resolved
@GordonSmith GordonSmith force-pushed the HPCC-32118-METRICS_FILTER_CASE branch from 61b7d7f to 16d0b94 Compare July 5, 2024 15:49
@GordonSmith GordonSmith requested a review from jeclrsg July 5, 2024 15:50
Introduced an option to toggle between case-sensitive and case-insensitive filtering

Signed-off-by: Gordon Smith <[email protected]>
@GordonSmith GordonSmith force-pushed the HPCC-32118-METRICS_FILTER_CASE branch from 16d0b94 to ac7e153 Compare July 11, 2024 10:31
@GordonSmith
Copy link
Member Author

Rebased for pull

@GordonSmith GordonSmith merged commit 212ca79 into hpcc-systems:candidate-9.2.x Jul 11, 2024
23 of 27 checks passed
@GordonSmith GordonSmith deleted the HPCC-32118-METRICS_FILTER_CASE branch July 11, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants