Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-32164 Minor improvements to new filename gathering code #18818

Merged
merged 1 commit into from
Jun 27, 2024
Merged

HPCC-32164 Minor improvements to new filename gathering code #18818

merged 1 commit into from
Jun 27, 2024

Conversation

ghalliday
Copy link
Member

@ghalliday ghalliday commented Jun 27, 2024 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@ghalliday ghalliday requested a review from jakesmith June 27, 2024 09:21
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32164

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR
Assigning user: [email protected]

@ghalliday
Copy link
Member Author

@jakesmith ignore whitespace when comparing

jakesmith
jakesmith reviewed Jun 27, 2024
View reviewed changes
ecl/hqlcpp/hqlcpp.ipp
}
if (type == SummaryType::None)
return;
//Spill files are meaningless in roxie, and no current benefit in recording them for hthor/thor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are SummaryType::JobTemp's useful?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They might be - in that they are written to persistent storage, so they are potentially noteworthy. We can always remove recording them at a later date, and they will not take up a significant amount of space.

jakesmith
jakesmith approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghalliday - looks good - 1 question.

@ghalliday ghalliday requested a review from jakesmith June 27, 2024 09:47
jakesmith
jakesmith reviewed Jun 27, 2024
View reviewed changes
common/workunit/workunit.cpp
const char *list = p->queryProp(xpath);
if (!list)
IPropertyTree * match = p->queryPropTree(xpath);
if (!match)
return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it make sense to return false if no xpath match ,but true (below) if !list ?
maybe it does - false means bad format (given other return false)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false means this workunit did not record the information. true means it recorded it, but it was empty.
I will add a comment to clarify.

jakesmith
jakesmith approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghalliday - approved - 1 side question

@ghalliday ghalliday merged commit 85bde6e into hpcc-systems:candidate-9.8.x Jun 27, 2024
46 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakesmith jakesmith jakesmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghalliday @jakesmith