-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-32110-1 Fixing issue with sec3, sect2, programlisting in PT_BR docs #18806
HPCC-32110-1 Fixing issue with sec3, sect2, programlisting in PT_BR docs #18806
Conversation
Signed-off-by: Michael Gardner <[email protected]>
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32110 Jirabot Action Result: |
@JamesDeFabia I think you're right about the diff we handed off to the Portuguese translation team being too large. This section that includes YAML_Filestruct-Placement needs to be looked at. It likely completely duplicates the section it had an id conflict with. But I don't speak Portuguese and I don't know how Greg wants to have the final book look like, so I made some minor changes and got rid of a smaller ENV duplicate section so the tags would line up properly for a build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my POV. I recognized enough to confirm that is was duplicated text.
@@ -1034,7 +1034,7 @@ | |||
<para><ulink | |||
url="https://github.com/hpcc-systems/HPCC-Platform/blob/master/helm/hpcc/docs/placements.md">https://github.com/hpcc-systems/HPCC-Platform/blob/master/helm/hpcc/docs/placements.md</ulink></para> | |||
|
|||
<sect4 id="YAML_FileStruct_Placement"> | |||
<sect4 id="YAML_FileStruct-Placement"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be sect3, and line 1098 should be /sect3.
If it builds I won't worry though..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It builds. I'm rather certain that entire ... is a duplicate that should be removed. But I'm not certain exactly what parts of it should be removed, which one is the correct one, etc. Greg made a lot of changes to that specific file and I think the people doing the translation were confused when they saw the diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so that 9.6.x can be built.
@g-pan I suspect this still isn't the correct fix because the section levels do not nest correctly. |
Type of change:
Checklist:
Smoketest:
Testing:
Test Build: https://github.com/Michael-Gardner/HPCC-Platform/actions/runs/9651366413/job/26619059050