Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-32104 Fix for xml:base issue with updated xml/xsl libraries #18797

Merged
merged 1 commit into from
Jun 24, 2024
Merged

HPCC-32104 Fix for xml:base issue with updated xml/xsl libraries #18797

merged 1 commit into from
Jun 24, 2024

Conversation

Michael-Gardner
Copy link
Contributor

@Michael-Gardner Michael-Gardner commented Jun 20, 2024 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Output documentation artifacts: https://github.com/Michael-Gardner/HPCC-Platform/releases/tag/community_vcpkg_9.8.x-1

Test build against Gordon's vcpkg changes to master: https://github.com/Michael-Gardner/HPCC-Platform/actions/runs/9602089938/job/26482132436

g-pan
g-pan approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@g-pan g-pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32104

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

GordonSmith
GordonSmith reviewed Jun 21, 2024
View reviewed changes
docs/BuildTools/cmake_config/HPCCSystemAdmin.txt Show resolved Hide resolved
docs/BuildTools/cmake_config/HPCCSystemAdmin.txt
@@ -37,5 +35,4 @@ IF(MAKE_DOCS)
ENDIF()
ENDFOREACH()

DOCBOOK_TO_HTML(${PORTAL_GEN_XSL} "${CMAKE_CURRENT_BINARY_DIR}/SecMgrInc.xml" ${PORTAL_HTML_DIR}/SecurityManagerGuide_${DOC_LANG} "security_manager_guide_html_${DOC_LANG}" "${HPCC_SOURCE_DIR}/docs/common/eclipsehelp.css" "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these files aren't needed anymore. Had discussions with @g-pan about fixing these issues and he informed me they shouldn't even be getting built. Greg has been investigating what needs to be removed in this jira https://hpccsystems.atlassian.net/browse/HPCC-31898.

@Michael-Gardner
HPCC-32104 Fix for xml:base issue with updated xml/xsl libraries
475a4fc 
    Removal of DOCBOOK_TO_HTML for SecurityManagerGuide as it
        is no longer used. See HPCC-31898
        File contained unresolved relative path xml:base issues

Signed-off-by: Michael Gardner <[email protected]>
@ghalliday ghalliday merged commit a5af4ee into hpcc-systems:master Jun 24, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GordonSmith GordonSmith GordonSmith approved these changes

@g-pan g-pan g-pan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Michael-Gardner @g-pan @GordonSmith @ghalliday