Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-31627 Remove legacy central node delay #18775

Merged
merged 1 commit into from
Jun 19, 2024
Merged

HPCC-31627 Remove legacy central node delay #18775

merged 1 commit into from
Jun 19, 2024

Conversation

jakesmith
Copy link
Member

@jakesmith jakesmith commented Jun 18, 2024 •
edited
Loading

Some very old redundant code that was not being hit until the HPCC-18382 changes were introduced caused random delays when sockets were connecting in Thor.
This was spuriously seen when SORT was connecting merge streams, introducing significant delays overall.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31627

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR
Changing assignee from: [email protected] to: [email protected]

@jakesmith jakesmith requested a review from ghalliday June 18, 2024 08:19
ghalliday
ghalliday approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you want to also delete the #define in jsocket.cpp(75)

@AttilaVamos
Copy link
Contributor

By my preliminary tests, this changes improve the performance significantly.

@jakesmith
HPCC-31627 Remove legacy central node delay
d5574ac 
Some very old redundant code that was not being hit until
the HPCC-18382 changes were introduced caused random delays
when sockets were connecting in Thor.
This was spuriously seen when SORT was connecting merge
streams, introducing significant delays overall.

Signed-off-by: Jake Smith <[email protected]>
@jakesmith jakesmith force-pushed the HPCC-31627-remove-central-node-delay branch from 57a8ce6 to d5574ac Compare June 18, 2024 12:59
ghalliday
ghalliday approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge when smoke tests have passed.

mckellyln
mckellyln reviewed Jun 18, 2024
View reviewed changes
system/jlib/jsocket.cpp
unsigned sleeptime = getRandom() % 1000;
StringBuffer s;
ep.getHostText(s);
DBGLOG("Connection to central node %s - sleeping %d milliseconds", s.str(), sleeptime);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I've ever seen this log message before ?
Probably there to avoid dropping SYNs when many connects at the same time ??
Increasing kernel somaxconn and application listen queues should help this.

mckellyln
mckellyln approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@mckellyln mckellyln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved also.

@ghalliday ghalliday merged commit ba93508 into hpcc-systems:candidate-9.4.x Jun 19, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mckellyln mckellyln mckellyln approved these changes

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakesmith @AttilaVamos @ghalliday @mckellyln