-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-32050 -HPCC Portuguese language Update 9.6 #18760
HPCC-32050 -HPCC Portuguese language Update 9.6 #18760
Conversation
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32050 Jirabot Action Result: |
review ongoing - builds ok - checking content - approval pending. |
in the case of the 2 conflicts in both cases the later or existing one is correct and this branch is introducing a regression. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments below
A few regressions being introduced which were addressed recently.
We could let them go and they would get picked up in the next round of translations, or we can resolve the conflict now and have a nice clean merge
|
||
<para><ulink url="???">https://www.elastic.co/</ulink></para> | ||
<para><ulink url="???">https://www.elastic.co/</ulink></para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just replace the ??? with the URL - as this format has expanded my text
url="???">https://www.elastic.co/elastic-stack/</ulink></para> | ||
<para><ulink | ||
url="???">https://www.elastic.co/elastic-stack/</ulink></para> | ||
</sect3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
<para><ulink | ||
url="???">https://github.com/hpcc-systems/HPCC-Platform/blob/master/helm/hpcc/docs/placements.md</ulink></para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please replace ??? with URL https://github.com/hpcc-systems/HPCC-Platform/blob/master/helm/hpcc/docs/placements.md
desenvolvedor:</para> | ||
|
||
<para><ulink | ||
url="???">https://github.com/hpcc-systems/HPCC-Platform/blob/master/helm/hpcc/docs/placements.md</ulink></para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please replace ??? with URL https://github.com/hpcc-systems/HPCC-Platform/blob/master/helm/hpcc/docs/placements.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Looks good. Please squash and resolve the clashes with the base branch and I will merge. |
8b0c13e
to
bbe9bd8
Compare
@ghalliday Done, Gary. Please, let me know if any additional steps are required. |
Still seeing conflicts. Unable to resolve as I don't have write access. There are 2 conflicts in the ContainerLogging.xml - the first is trivial (whitespace in the XML) either way is fine. |
only @vfumene can resolve this. Here are the suggested steps: From Git Command Line: Should return "unable to "Auto-Merge" CONFLICT (Content) error: <message> " Open offending files (use any text editor) : ConfigureValues.xml and ContainerLogging.xml Issue command: This may open a commit msg file - edit that file - if necessary - close and should return to command prompt. Issue command: After push completes Verify changes here in GitHub |
Signed-off-by: Valdir Fumene Junior <[email protected]> HPCC-32050 -HPCC Portuguese language Update 9.6 tSigned-off-by: Valdir Fumene Junior <[email protected]>
bbe9bd8
to
02b1fcc
Compare
Guys, files updated. Please, check if it is ok. |
conflict looks resolved. Approved to merge. |
Type of change:
Checklist:
Smoketest:
Testing: