Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-32050 -HPCC Portuguese language Update 9.6 #18760

Conversation

vfumene
Copy link
Contributor

@vfumene vfumene commented Jun 12, 2024

Type of change:

  • [x ] This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • [x ] My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • [x ] The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • [ x] I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32050

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

@JamesDeFabia JamesDeFabia requested a review from g-pan June 12, 2024 17:40
@g-pan
Copy link
Member

g-pan commented Jun 13, 2024

review ongoing - builds ok - checking content - approval pending.

@g-pan
Copy link
Member

g-pan commented Jun 13, 2024

in the case of the 2 conflicts in both cases the later or existing one is correct and this branch is introducing a regression.
Both cases the existing should remain.

Copy link
Member

@g-pan g-pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments below
A few regressions being introduced which were addressed recently.
We could let them go and they would get picked up in the next round of translations, or we can resolve the conflict now and have a nice clean merge


<para><ulink url="???">https://www.elastic.co/</ulink></para>
<para><ulink url="???">https://www.elastic.co/</ulink></para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just replace the ??? with the URL - as this format has expanded my text

url="???">https://www.elastic.co/elastic-stack/</ulink></para>
<para><ulink
url="???">https://www.elastic.co/elastic-stack/</ulink></para>
</sect3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


<para><ulink
url="???">https://github.com/hpcc-systems/HPCC-Platform/blob/master/helm/hpcc/docs/placements.md</ulink></para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

desenvolvedor:</para>

<para><ulink
url="???">https://github.com/hpcc-systems/HPCC-Platform/blob/master/helm/hpcc/docs/placements.md</ulink></para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesDeFabia
Copy link
Contributor

@vfumene Please let @g-pan know when you have made the requested changes and pushed.

Copy link
Member

@g-pan g-pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@ghalliday
Copy link
Member

Looks good. Please squash and resolve the clashes with the base branch and I will merge.

@vfumene vfumene force-pushed the portuguese_lang_update_0527_candidate-9.6.x branch from 8b0c13e to bbe9bd8 Compare June 18, 2024 19:04
@vfumene
Copy link
Contributor Author

vfumene commented Jun 18, 2024

@ghalliday Done, Gary. Please, let me know if any additional steps are required.

@g-pan
Copy link
Member

g-pan commented Jun 18, 2024

Still seeing conflicts. Unable to resolve as I don't have write access.
The ConfigureValues.xml conflict looks to be a case of both changes need to be kept - both the link in Candidate-9.6 and the Port_lang_update need to keep.

There are 2 conflicts in the ContainerLogging.xml - the first is trivial (whitespace in the XML) either way is fine.
The second conflict seems like the Port_Lang_update branch needs to keep.

@g-pan
Copy link
Member

g-pan commented Jun 18, 2024

only @vfumene can resolve this. Here are the suggested steps:
Use this technique to resolve a CONFLICT (in this Pull Request):

From Git Command Line:
(go to your branch portuguese_lang_update_)
Issue command:
$ git rebase

Should return "unable to "Auto-Merge" CONFLICT (Content) error: <message> "

Open offending files (use any text editor) : ConfigureValues.xml and ContainerLogging.xml
Edit files to remove conflict markers (<<<<<, =====, and >>>>>) and ensure required changes exist
(the last comment above) as you require.
Save the files
Then issue :
$ git add filename.xml
Add the modified files back into the branch

Issue command:
$ git rebase --continue

This may open a commit msg file - edit that file - if necessary - close and should return to command prompt.

Issue command:
$ git push -f origin branchname

After push completes Verify changes here in GitHub

Signed-off-by: Valdir Fumene Junior <[email protected]>

HPCC-32050 -HPCC Portuguese language Update 9.6

tSigned-off-by: Valdir Fumene Junior <[email protected]>
@vfumene vfumene force-pushed the portuguese_lang_update_0527_candidate-9.6.x branch from bbe9bd8 to 02b1fcc Compare June 19, 2024 14:46
@vfumene
Copy link
Contributor Author

vfumene commented Jun 19, 2024

Guys, files updated. Please, check if it is ok.

@g-pan
Copy link
Member

g-pan commented Jun 19, 2024

conflict looks resolved.

Approved to merge.

@ghalliday ghalliday merged commit 2f8b8b2 into hpcc-systems:candidate-9.6.x Jun 20, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants