-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-31901 Add Jfrog internal package releases to build-assets #18723
HPCC-31901 Add Jfrog internal package releases to build-assets #18723
Conversation
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31901 Jirabot Action Result: |
bae74b8
to
38bc041
Compare
@GordonSmith allows us to push to internal jfrog repository for debian, rpm, windows and macos builds. |
distribution=$( echo "${_package}" | awk -F '.' '{print $4;}' ) | ||
curl -u${{ secrets.JFROG_USERNAME }}:${{ secrets.JFROG_PASSWORD }} -XPUT "https://${{ secrets.JFROG_REGISTRY }}/hpccpl-rpm-local/LN/${distribution}/x86_64/${_package}" -T ${{ needs.preamble.outputs.folder_build }}/${_package} | ||
done | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine - but was wondering why using curl
over jf
cli?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a hard time getting jf rt curl
to respect the credentials that we included in the jf setup for distributing docker and then take in parameters for the curl.
I spent a while trying to finesse it but then fell back to just using curl with the token because it worked without any headache.
Signed-off-by: Michael Gardner <[email protected]>
38bc041
to
ae8337e
Compare
@GordonSmith removed those blank lines |
7e1f840
into
hpcc-systems:candidate-8.12.x
Type of change:
Checklist:
Smoketest:
Testing: