Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-31886 LogAccess Trace/Span ID filtering #18680

Merged
merged 1 commit into from
Jun 13, 2024
Merged

HPCC-31886 LogAccess Trace/Span ID filtering #18680

merged 1 commit into from
Jun 13, 2024

Conversation

rpastrana
Copy link
Member

@rpastrana rpastrana commented May 17, 2024 •
edited
Loading

  • Exposes trace/span filter logic in wslogaccess
  • Adds logic generate Trace/span id filter commands

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31886

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR
Assigning user: [email protected]

@rpastrana rpastrana requested a review from ghalliday May 31, 2024 13:15
@ghalliday
Copy link
Member

@rpastrana some of the smoke tests are failing.

ghalliday
ghalliday requested changes Jun 7, 2024
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks sensible, but missing related header change I suspect.

@rpastrana
Copy link
Member Author

I'm not sure how/when we lost those header file changes, recreating them now...

@rpastrana
HPCC-31886 LogAccess Trace/Span ID filtering
b507640 
- Exposes trace/span filter logic in wslogaccess
- Adds logic generate Trace/span id filter commands

Signed-off-by: Rodrigo Pastrana <[email protected]>
@rpastrana rpastrana force-pushed the HPCC-31886-LogAccessFilterbyTracespan branch from 301e0ec to b507640 Compare June 7, 2024 15:38
rpastrana
rpastrana commented Jun 7, 2024
View reviewed changes
esp/scm/ws_logaccess.ecm
@@ -25,7 +25,9 @@ ESPenum LogAccessType : int
BySourceInstance(5, "BySourceInstance"),
BySourceNode(6, "BySourceNode"),
ByFieldName(7, "ByFieldName"),
ByPod(8, "ByPod")
ByPod(8, "ByPod"),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asselitx this PR adds a couple of entries in a number of ECM enumerations which I want to annotate w/ the appropriate interface version, but I found no mechanism to do so. Is there a way to declare the new entries to require at least client version 1.06+ ? Thanks.

@rpastrana rpastrana requested a review from ghalliday June 7, 2024 15:42
ghalliday
ghalliday approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible.

@ghalliday ghalliday merged commit 609deff into hpcc-systems:candidate-9.4.x Jun 13, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpastrana @ghalliday