Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-31715 Change the default field translation mode #18601

Merged
merged 1 commit into from
May 28, 2024
Merged

HPCC-31715 Change the default field translation mode #18601

merged 1 commit into from
May 28, 2024

Conversation

jackdelv
Copy link
Contributor

@jackdelv jackdelv commented May 1, 2024 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jackdelv jackdelv requested a review from ghalliday May 1, 2024 12:28
@jackdelv
Copy link
Contributor Author

jackdelv commented May 1, 2024

@ghalliday I have added the code for processing the fields in this commit alongside the change to the default for the tests to pass. Let me know if you wanted just the changes to the default.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31715

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

@ghalliday ghalliday closed this May 2, 2024
@ghalliday ghalliday reopened this May 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31715

Jirabot Action Result:

@ghalliday
Copy link
Member

@jackdelv please can you rebase onto the lastest master - it will remove some of these changes.

@jackdelv jackdelv force-pushed the changeDefaultFieldTranslation branch from 42f21f3 to 5122080 Compare May 7, 2024 15:52
@jackdelv
Copy link
Contributor Author

jackdelv commented May 7, 2024

@ghalliday Rebased to latest master.

ghalliday
ghalliday reviewed May 10, 2024
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackdelv a few changes that should be in 9.4 rather than this - which should only change the defaults. If you agree please split the PR In two again. Thanks.

initfiles/componentfiles/configschema/xsd/eclagent.xsd Outdated
<xs:enumeration value="payload" hpcc:displayName="Payload" hpcc:description=""/>
<xs:enumeration value="payloadRemoveOnly" hpcc:displayName="PayloadRemoveOnly" hpcc:description=""/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a change that should be in 9.4.x. I will tag the others as well.

initfiles/componentfiles/configschema/xsd/roxie.xsd Outdated
<xs:enumeration value="payload" hpcc:displayName="Payload" hpcc:description=""/>
<xs:enumeration value="payloadRemoveOnly" hpcc:displayName="PayloadRemoveOnly" hpcc:description=""/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a change that should be in 9.4.x

initfiles/componentfiles/configschema/xsd/thor.xsd Outdated
<xs:enumeration value="payload" hpcc:displayName="Payload" hpcc:description=""/>
<xs:enumeration value="payloadRemoveOnly" hpcc:displayName="PayloadRemoveOnly" hpcc:description=""/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a change that should be in 9.4.x

initfiles/componentfiles/configxml/eclagent_config.xsd.in Outdated
@@ -201,6 +201,7 @@
<xs:enumeration value="false"/>
<xs:enumeration value="true"/>
<xs:enumeration value="payload"/>
<xs:enumeration value="payloadRemoveOnly"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a change that should be in 9.4.x

initfiles/componentfiles/configxml/roxie.xsd.in Outdated
@@ -649,6 +649,7 @@
<xs:enumeration value="false"/>
<xs:enumeration value="true"/>
<xs:enumeration value="payload"/>
<xs:enumeration value="payloadRemoveOnly"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a change that should be in 9.4.x

initfiles/componentfiles/configxml/thor.xsd.in Outdated
@@ -688,6 +688,7 @@
<xs:enumeration value="false"/>
<xs:enumeration value="true"/>
<xs:enumeration value="payload"/>
<xs:enumeration value="payloadRemoveOnly"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a change that should be in 9.4.x

testing/regress/ecl/layouttrans.ecl Outdated
@@ -26,7 +26,7 @@ version := #IFDEFINED(root.version, 1);

//--- end of version configuration ---

#option ('layoutTranslation', true);
#option ('layoutTranslation', 'payload');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a change that should be in 9.4.x

testing/regress/ecl/sqtrans.ecl Outdated
@@ -22,6 +22,8 @@ multiPart := #IFDEFINED(root.multiPart, false);

//--- end of version configuration ---

#option('layoutTranslation', 'payload');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a change that should be in 9.4.x

testing/regress/ecl/translatedisk.ecl Outdated
@@ -27,7 +27,7 @@ optRemoteRead := #IFDEFINED(root.optRemoteRead, true);

#onwarning(2036, ignore);
#onwarning(4522, ignore);
#option ('layoutTranslation', true);
#option ('layoutTranslation', 'payload');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a change that should be in 9.4.x

@jackdelv jackdelv force-pushed the changeDefaultFieldTranslation branch from 5122080 to d42cfb7 Compare May 17, 2024 18:02
@jackdelv
Copy link
Contributor Author

@ghalliday I have rebased to remove the changes that went into 9.4.x.

@jackdelv jackdelv requested a review from ghalliday May 17, 2024 18:05
@jackdelv jackdelv force-pushed the changeDefaultFieldTranslation branch from d42cfb7 to af68f8c Compare May 20, 2024 15:13
ghalliday
ghalliday reviewed May 23, 2024
View reviewed changes
helm/hpcc/values.schema.json Outdated
@@ -1865,8 +1865,8 @@
"description": "Should the index node memory allocation flush the cache and retry if memory allocation fails"
},
"fieldTranslationEnabled": {
"default": "payload",
"enum": ["false", "true", "payload"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackdelv this change also needs to be in the previous build otherwise the option cannot be configured.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #18694

@jackdelv jackdelv force-pushed the changeDefaultFieldTranslation branch from af68f8c to 3b87b55 Compare May 23, 2024 15:38
@jackdelv
Copy link
Contributor Author

jackdelv commented May 23, 2024 •
edited
Loading

@ghalliday Rebased to remove change from #18694

@jackdelv jackdelv requested a review from ghalliday May 23, 2024 15:39
@ghalliday ghalliday merged commit db29ee9 into hpcc-systems:master May 28, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackdelv @ghalliday