Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-31571 Parquet Plugin supports invalid compression options #18498

Merged
merged 1 commit into from
Apr 11, 2024
Merged

HPCC-31571 Parquet Plugin supports invalid compression options #18498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/parquet/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ dataset := ParquetIO.Read(layout, '/source/directory/data.parquet');

The Write function empowers ECL programmers to write ECL datasets to Parquet files. By leveraging the Parquet format's columnar storage capabilities, this function provides efficient compression and optimized storage for data. There is an optional argument that sets the overwrite behavior of the plugin. The default value is false meaning it will throw an error if the target file already exists. If overwrite is set to true the plugin will check for files that match the target path passed in and delete them first before writing new files.

The Parquet Plugin supports all available Arrow compression types. Specifying the compression when writing is optional and defaults to Uncompressed. The options for compressing your files are Snappy, GZip, Brotli, LZ4, LZ4Frame, LZ4Hadoop, ZSTD, Uncompressed.
The Parquet Plugin supports all available Arrow compression types. Specifying the compression when writing is optional and defaults to Uncompressed. The options for compressing your files are Snappy, GZip, Brotli, LZ4, ZSTD, Uncompressed.

```
overwriteOption := TRUE;
Expand Down
4 changes: 0 additions & 4 deletions plugins/parquet/parquetembed.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1874,10 +1874,6 @@ ParquetEmbedFunctionContext::ParquetEmbedFunctionContext(const IContextLogger &_
compressionOption = arrow::Compression::BROTLI;
else if (strieq(val, "lz4"))
compressionOption = arrow::Compression::LZ4;
else if (strieq(val, "lz4frame"))
compressionOption = arrow::Compression::LZ4_FRAME;
else if (strieq(val, "lz4hadoop"))
compressionOption = arrow::Compression::LZ4_HADOOP;
else if (strieq(val, "zstd"))
compressionOption = arrow::Compression::ZSTD;
else if (strieq(val, "uncompressed"))
Expand Down
Loading