Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-31561 Add name of filesDefaultUser to log statements whenever used #18487

Closed

Conversation

kenrowland
Copy link
Contributor

@kenrowland kenrowland commented Apr 4, 2024

Added name of filesDefaultUser to log statement when default user is applied

Signed-Off-By: Kenneth Rowland [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Added name of filesDefaultUser to log statement when default user is applied

Signed-Off-By: Kenneth Rowland [email protected]
@kenrowland kenrowland requested a review from jakesmith April 4, 2024 18:33
Copy link

github-actions bot commented Apr 4, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31561

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

@@ -131,7 +131,8 @@ class CDaliLdapConnection: implements IDaliLdapConnection, public CInterface
{
username.append(filesdefaultuser);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We suspected it (filedefaultuser) could be blank (since it's not configured in any cloud system), and taking this commit into my test image that proved to be the case.

As discussed offline, I don't think there's any sensible case for allowing this to continue if filesDefaultUser is empty here (which we've seen it do).
If empty, it should return SecAccess_None

However, I am worried what it might break. Nothing should be relying on this code path, but...

Discussed briefly with Gavin earlier and we think there should be an option added to in effect disable the defaultuser functionality altogether (with the option defaulted off for now).
Then it be turned on via config and tested (in e.g. our TFE clusters), to discover what is relying on the default user.

I don't think there's much value in merging this one right now, we know it's always blank in cloud.
@kenrowland - can you open a new JIRA to add an option to conditionally disable use of the default user via configuration? Thanks.

@kenrowland kenrowland closed this Apr 5, 2024
@kenrowland
Copy link
Contributor Author

Opened https://hpccsystems.atlassian.net/browse/HPCC-31574 to address comments above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants