Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-30690 Nested stats from workers not accumulated correctly #18428

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

shamser
Copy link
Contributor

@shamser shamser commented Mar 20, 2024

Nested stats from worker nodes were being merged rather than set, meaning that the updates of the nested stats from the worker were added to the stats recorded previously. Graph master should 'set' the stats from workers rather than 'merge'.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@shamser shamser requested a review from ghalliday March 20, 2024 11:57
@shamser shamser changed the base branch from master to candidate-9.2.x March 20, 2024 12:20
@shamser shamser changed the base branch from candidate-9.2.x to candidate-9.6.x March 20, 2024 12:20
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you target this to 9.4.x though - since it is a bug fix.

@ghalliday ghalliday changed the base branch from candidate-9.6.x to candidate-9.4.x March 21, 2024 16:07
Nested stats from worker nodes were being merged rather than set,
meaning that the updates of the nested stats from the worker were
added to the stats recorded previously.  Graph master should 'set'
the stats from workers rather than 'merge'.

Signed-off-by: Shamser Ahmed <[email protected]>
@ghalliday ghalliday merged commit 3bd0ef5 into hpcc-systems:candidate-9.4.x Mar 22, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants