HPCC-30868 Report dropzone name and scope when scope access denied #18371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://track.hpccsystems.com/browse/HPCC-30868 |
jakesmith
reviewed
Mar 5, 2024
dali/dfu/dfurun.cpp
Outdated
| @@ -614,7 +624,7 @@ class CDFUengine: public CInterface, implements IDFUengine | |||
|
|
|||
| SecAccessFlags perm = queryDistributedFileDirectory().getFDescPermissions(fd,user,auditflags); | |||
| StringBuffer name; | |||
| ensureFilePermissions(getFDescName(fd,name),perm,write); | |||
| ensureFilePermissions(true,nullptr,getFDescName(fd,name),perm,write); | |||
There was a problem hiding this comment.
is both, bool legacyPhysicalPerms and const char * planeName params necessary?
Can it be assume that if planeName == nullptr, then it is legacy ?
There was a problem hiding this comment.
Yes, if planeName == nullptr, it is legacy. The legacyPhysicalPerms will be removed.
jakesmith
reviewed
Mar 5, 2024
When accessing a dropzone scope and the scope access denied, the dropzone name and scope are added to the error message. Signed-off-by: wangkx <[email protected]>
|
@jakesmith I made the changes and squashed. Please review. |
jakesmith
reviewed
Mar 7, 2024
| throw makeStringExceptionV(DFSERR_CreateAccessDenied, "Create permission denied for file scope: %s on DropZone: %s", dlfn.get(), planeName); | ||
| else | ||
| throw makeStringExceptionV(DFSERR_LookupAccessDenied, "Lookup permission denied for file scope: %s on DropZone: %s", dlfn.get(), planeName); | ||
| } | ||
| if (write) |
There was a problem hiding this comment.
personal: since the above block can never fall through, this is really an else if (coding as such would clarify at a glance).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accessing a dropzone scope and the scope access denied, the dropzone name and scope are added to the error message.
Type of change:
Checklist:
Smoketest:
Testing: