Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-31258 Initial File structure and page layout creation #18356

Merged
merged 1 commit into from
Mar 14, 2024
Merged

HPCC-31258 Initial File structure and page layout creation #18356

merged 1 commit into from
Mar 14, 2024

Conversation

kunalaswani
Copy link
Contributor

@kunalaswani kunalaswani commented Feb 28, 2024 •
edited
Loading

This is to create the initial design of Sasha in Cloud. Feature availability to come as it is created.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@kunalaswani kunalaswani requested a review from jeclrsg February 28, 2024 18:28
@github-actions GitHub Actions
Copy link

https://track.hpccsystems.com/browse/HPCC-31258
Jira updated

jeclrsg
jeclrsg reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunalaswani There are a lot of lint errors getting annotated by GH Actions

@kunalaswani kunalaswani requested a review from jeclrsg February 28, 2024 20:23
jeclrsg
jeclrsg requested changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think this should be more similar to your Dali Admin PR(s), both with respect to the changes to routes.tsx and the Sasha.tsx component, ie using FluentUI components.

esp/src/src-react/routes.tsx Outdated Show resolved Hide resolved
esp/src/src-react/components/Sasha.tsx Show resolved Hide resolved
@kunalaswani kunalaswani requested a review from jeclrsg March 4, 2024 15:36
ghalliday
ghalliday reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about embedded text

esp/src/src-react/components/Sasha.tsx Outdated
selectedKey={selectedOption}
onChange={handleOptionChange}
options={[
{ key: "", text: "Select an option" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these display strings be i18n?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghalliday corrected

@kunalaswani kunalaswani force-pushed the HPCC-31258 branch 2 times, most recently from 3b3f54b to 66fcef3 Compare March 7, 2024 21:24
@ghalliday
Copy link
Member

@kunalaswani if you are making changes to a PR, please push them as separate commits, which can than be squashed later - otherwise it is hard to spot the changes. Also, you need to re-request reviews.

@ghalliday ghalliday requested a review from jeclrsg March 8, 2024 09:57
jeclrsg
jeclrsg requested changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunalaswani just noticed a couple other small things, other strings that should be using the translations file

esp/src/src-react/components/Sasha.tsx Outdated Show resolved Hide resolved
esp/src/src-react/components/Sasha.tsx Outdated Show resolved Hide resolved
esp/src/src-react/components/Sasha.tsx Outdated Show resolved Hide resolved
@kunalaswani
HPCC-31258 Initial File structure and page layout creation
55655dd 
This is to create the initial design of Sasha in Cloud.
Feature availability to come as it is created.

Signed-off-by: Kunal Aswani <[email protected]>
@kunalaswani kunalaswani requested a review from jeclrsg March 11, 2024 13:45
@kunalaswani kunalaswani changed the base branch from master to candidate-9.6.x March 12, 2024 14:43
@ghalliday ghalliday merged commit b016cf6 into hpcc-systems:candidate-9.6.x Mar 14, 2024
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg approved these changes

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kunalaswani @ghalliday @jeclrsg