HPCC-31196 Add "disconnect", "unlock", etc. to WsDali #18342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "disconnect", "unlock", "settracetransactions", "settraceslowtransactions", "cleartracetransactions", "save" (from dalidiag) to the WsDali service. Signed-off-by: wangkx <[email protected]>
|
https://track.hpccsystems.com/browse/HPCC-31196 |
jakesmith
reviewed
Mar 4, 2024
esp/scm/ws_dali.ecm
Outdated
| @@ -151,8 +151,36 @@ ESPrequest [nil_remove] GetSDSSubscribersRequest | |||
| { | |||
| }; | |||
|
|
|||
| ESPrequest [nil_remove] DisconnectClientConnectionRequest | |||
| { | |||
| string URL; | |||
There was a problem hiding this comment.
a url is misleading. It's a host:port. Endpoint would be better.
|
|
||
| const char* url = req.getURL(); | ||
| if (isEmptyString(url)) | ||
| throw makeStringException(ECLWATCH_INVALID_INPUT, "URL not specified."); |
There was a problem hiding this comment.
see prev. comment re. "endpoint"
| throw makeStringException(ECLWATCH_INVALID_INPUT, "ConnectionID not specified."); | ||
|
|
||
| MemoryBuffer mb; | ||
| mb.append("unlock").append(strtoll(connectionIdHex, nullptr, 16)).append(req.getClose()); |
There was a problem hiding this comment.
I had to check this, because it's not clear from the dalidiag usage (not a new issue) that it expects a hex number.
I think worth updating the daliadmin usage text at the same time to note it expect the connectionID to be hex.
1. Inside the DisconnectClientConnectionRequest, rename the URL to Endpoint. 2. Update the usage text for dalidiag -unlock. Signed-off-by: wangkx <[email protected]>
|
@jakesmith please review my changes and let me know if I miss any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "disconnect", "unlock", "settracetransactions", "settraceslowtransactions", "cleartracetransactions", "save" (from dalidiag) to the WsDali service.
Type of change:
Checklist:
Smoketest:
Testing: