HPCC-31347 Jtrace Jlog::export should honor noexcept declaration

[rpastrana]

• Catches all excptions thrown in noexcept fn
• Reports export failure if exception caught

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Cloud-compatibility
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Smoketest:

• Send notifications about my Pull Request position in Smoketest queue.
• Test my draft Pull Request.

Testing:

[github-actions]

https://track.hpccsystems.com/browse/HPCC-31347
Jira updated

[ghalliday]

This is tackling the symptom rather than the cause. Looking closer, I think the problem is that printAttributes() calls UNIMPLEMENTED - which throws an exception. With this change that will silently be ignored (and leak the exception).
Better would be to change how that error is reported.

The commit message also contains a couple of typos.

[rpastrana]

This is tackling the symptom rather than the cause. Looking closer, I think the problem is that printAttributes() calls UNIMPLEMENTED - which throws an exception. With this change that will silently be ignored (and leak the exception). Better would be to change how that error is reported.

The commit message also contains a couple of typos.

hmmm we discussed the difficulty in determining all possible exceptions before I submitted this PR, maybe that doesn't apply here. Even though it might be targeting symptoms, preventing uncaught exceptions in a noexcept, non-critical function seems warranted. Do you disagree, and would prefer we attempt to tackle all possible exceptions individually?
I feel this function's failure should not affect the host process, failing silently seems preferred.

Also, unfortunately my eyes are not as sharp as yours and I was not able to spot the specific exception caught by coverity, nor the the UNIMPLEMENTED call you mentioned {btw github pilot couldn't identify any possible IExceptions for what that's worth)

Also, my best interpretation of "Better would be to change how that error is reported." is vague (find the UNIMPLEMENTED line, and log, but don't throw?, catch StringExceptions log message release exception, return failure? catch StringException, release exception, return failure?, catch iexceptions?)

[ghalliday]

See comment for suggested change.
I found the cause of the exception by reading the coverity report carefully - it narrowed down where the exception was thrown.

[ghalliday]

The best code for this situation would be something like:

catch (IException * e);
{
   EXCLOG(e, "JLogSpanExporter::Export");
   e->Release();
   return opentelemetry::sdk::common::ExportResult::kFailure;
 }

This will ensure that the issue does get logged, and will cleanly catch and release the exception.

[ghalliday]

Thanks. Please squash and I will merge

[rpastrana]

@ghalliday done