Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-30888 support ECLIDE build with github action #18218

Conversation

xwang2713
Copy link
Member

Also add code sign for Windows builds

Since this is the first time I edit github action workflow some code may not 100% following our guideline.
Hopefully Gordon and Michael can help me review it.

The test will require having encoded code sign certificate. I tested with following encoding:
[convert]::ToBase64String((Get-Content -path "hpcc_code_signing.pfx" -Encoding byte))

I can't make base64 encode/decode work with github action

I verify the yaml with yamllint
yamllint -d "{extends: relaxed, rules: {line-length: disable}}" build-assets.yml
Removed some end spaces according to above output

signed off by [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

I did test the code in a separated private branch
I will ask Michael to test it

Copy link

https://track.hpccsystems.com/browse/HPCC-30888
Jira not updated (user does not match)

@xwang2713 xwang2713 requested a review from GordonSmith January 12, 2024 16:50
@xwang2713
Copy link
Member Author

I assigned JIRA https://track.hpccsystems.com/browse/HPCC-30888 to my name, xwang2713

.github/workflows/build-assets.yml Outdated Show resolved Hide resolved
.github/workflows/build-assets.yml Outdated Show resolved Hide resolved
@xwang2713 xwang2713 force-pushed the HPCC-30888-support-IDE-build-w-Github-Action branch from 24015ec to 7a3955b Compare January 18, 2024 14:42
@xwang2713 xwang2713 requested a review from GordonSmith January 18, 2024 14:45
Also add code sign for Windows builds
@xwang2713 xwang2713 force-pushed the HPCC-30888-support-IDE-build-w-Github-Action branch from da08486 to 9280ce0 Compare January 23, 2024 15:22
Copy link
Contributor

@Michael-Gardner Michael-Gardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks solid. I made some changes that Ming took to his branch regarding eclide builds and upload-artifact / download-artifact instead of curl. It's now running for users who are not hpcc-systems.

For SIGNING_CERTIFICATE I was able to get it to work with a cert converted to the pks12 format and then encoded using the linux base64 utility. The cert will likely need to be added to our secrets.

Successful run of this commit is here: https://github.com/Michael-Gardner/HPCC-Platform/actions/runs/7627989492

Artifacts present here: https://github.com/Michael-Gardner/HPCC-Platform/releases/tag/community_ming-30888-pr1

@Michael-Gardner
Copy link
Contributor

@ghalliday should now be ready for a final look

@ghalliday ghalliday merged commit 6ef9d30 into hpcc-systems:candidate-9.4.x Jan 25, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants