HPCC-30888 support ECLIDE build with github action #18218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add code sign for Windows builds
Since this is the first time I edit github action workflow some code may not 100% following our guideline.
Hopefully Gordon and Michael can help me review it.
The test will require having encoded code sign certificate. I tested with following encoding:
[convert]::ToBase64String((Get-Content -path "hpcc_code_signing.pfx" -Encoding byte))
I can't make base64 encode/decode work with github action
I verify the yaml with yamllint
yamllint -d "{extends: relaxed, rules: {line-length: disable}}" build-assets.yml
Removed some end spaces according to above output
signed off by [email protected]
Type of change:
Checklist:
Smoketest:
Testing:
I did test the code in a separated private branch
I will ask Michael to test it