HPCC-30641 Fetch pod logs for ZAP report

[wangkx]

Before this PR, WU ZAP report has only one log file which contains the WU log lines from all pods. In this PR, each pod where the WU works on has a log file in the WU ZAP report.

The createWULogFile() is replaced by new readWULogToFiles() which does the following: 1. check whether Remote Log Accessor is available or not. 2. find out the pods where the WU works on. 3. read the log lines into the log files for the pods.

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Cloud-compatibility
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Smoketest:

• Send notifications about my Pull Request position in Smoketest queue.
• Test my draft Pull Request.

Testing:

[github-actions]

https://track.hpccsystems.com/browse/HPCC-30641
Jira updated

[jakesmith]

@wangkx - looks ok afaict, I assume tested.
Have you also tested that bare-metal ZAP report creation still works in bare-metal?

[wangkx]

I tested ZAP report creation on both cloud and bare metal. The ZAP reports are created fine.

[wangkx]

@jakesmith In bare metal, the ECLWatch does show a warning: "Warning: may not be able to include log file because Remote Log Access plug-in is not available!" Should I change the code (in CWsWorkunitsEx::onWUGetZAPInfo()) to only show the warning if isContainerized()?

[jakesmith]

@jakesmith In bare metal, the ECLWatch does show a warning: "Warning: may not be able to include log file because Remote Log Access plug-in is not available!" Should I change the code (in CWsWorkunitsEx::onWUGetZAPInfo()) to only show the warning if isContainerized()?

Does it ever try to use the Remote Log Access interface in bare-metal at the moment?

If not, then yes the warning should be suppressed - but if not new, change that in a separate PR.

If it Remote Log Access can be hit in bare-metal - when does it go one route vs the other?

[wangkx]

Does it ever try to use the Remote Log Access interface in bare-metal at the moment?

no

If not, then yes the warning should be suppressed - but if not new, change that in a separate PR.

It is from #16957. I will create a separate JIRA/PR.

[wangkx]

https://track.hpccsystems.com/browse/HPCC-31122

[jakesmith]

@wangkx - looks good.

[wangkx]

@ghalliday please merge this PR.