Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-31074 Refactor ECL Archive Widget to React #18199

Merged
merged 1 commit into from
Feb 6, 2024
Merged

HPCC-31074 Refactor ECL Archive Widget to React #18199

merged 1 commit into from
Feb 6, 2024

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Jan 9, 2024 •
edited
Loading

Fixes resize issue with ECL Archive Widget. Also is first step for direct link to lines of ECL Code (from metrics and error/warning messages).

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg January 9, 2024 15:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

https://track.hpccsystems.com/browse/HPCC-31074
Jira updated

@GordonSmith GordonSmith force-pushed the HPCC-31074-ECL_ARCHIVE_REACT branch from fc1b80d to cb90461 Compare January 9, 2024 15:51
jeclrsg
jeclrsg requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith mentioned a couple of small issues. I also added a comment to the Jira with a screenshot about differences I noticed when comparing this branch to a previous version (which would have been 9.4.18 in my case).

esp/src/src-react/hooks/metrics.ts Outdated Show resolved Hide resolved
esp/src/src-react/components/ECLArchive.tsx Outdated Show resolved Hide resolved
@GordonSmith GordonSmith marked this pull request as draft January 17, 2024 14:40
@GordonSmith GordonSmith force-pushed the HPCC-31074-ECL_ARCHIVE_REACT branch from cb90461 to ebd16d9 Compare January 17, 2024 14:45
@GordonSmith GordonSmith force-pushed the HPCC-31074-ECL_ARCHIVE_REACT branch from 5165b18 to fcdacf2 Compare January 25, 2024 07:53
@GordonSmith GordonSmith marked this pull request as ready for review January 25, 2024 12:40
@GordonSmith GordonSmith requested a review from jeclrsg January 25, 2024 12:40
@GordonSmith
Copy link
Member Author

@jeclrsg - this is ready for review now...

@GordonSmith GordonSmith force-pushed the HPCC-31074-ECL_ARCHIVE_REACT branch from fcdacf2 to d1cd17e Compare January 25, 2024 12:47
@GordonSmith
Copy link
Member Author

@jeclrsg bump

jeclrsg
jeclrsg requested changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith two or three small things. Looks good though.

esp/src/src-react/util/metricArchive.ts Outdated
if (!this.sourcePath_TimeTotalExecute[definition.filePath]) {
this.sourcePath_TimeTotalExecute[definition.filePath] = { total: 0, line: {} };
}
// if (idx === 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of lines of commented out code here?

esp/src/src-react/components/ECLArchiveTree.tsx Outdated
const { fileTimePct, content, ...treeItemProps } = flatTreeItem.getTreeItemProps();
return <TreeItem {...treeItemProps} onClick={onClick}>
<TreeItemLayout
// expandIcon={
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit of commented out code

esp/src/src-react/components/ECLArchive.tsx
};

const nestedFilterDefault: WUDetails.RequestNS.NestedFilter = {
Depth: 999999,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default should be 0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not here - really it should match: https://github.com/hpcc-systems/HPCC-Platform/blob/master/esp/src/src/ECLArchiveWidget.ts#L172-L201

I will tweak...

@GordonSmith
HPCC-31074 Refactor ECL Archive Widget to React
840ae72 
Fixes resize issue with ECL Archive Widget.  Also is first step for direct
link to lines of ECL Code https://track.hpccsystems.com/browse/HPCC-30997

Signed-off-by: Gordon Smith <[email protected]>
@GordonSmith GordonSmith force-pushed the HPCC-31074-ECL_ARCHIVE_REACT branch from d1cd17e to 840ae72 Compare January 26, 2024 07:16
@GordonSmith GordonSmith requested a review from jeclrsg January 26, 2024 07:16
@GordonSmith
Copy link
Member Author

@jeclrsg - please re-review

@GordonSmith GordonSmith merged commit dbf320f into hpcc-systems:candidate-9.2.x Feb 6, 2024
50 checks passed
@GordonSmith GordonSmith deleted the HPCC-31074-ECL_ARCHIVE_REACT branch February 6, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonSmith @jeclrsg