Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-31053 Metrics layout fails to persist on top level change #18168

Merged
merged 1 commit into from
Jan 3, 2024
Merged

HPCC-31053 Metrics layout fails to persist on top level change #18168

merged 1 commit into from
Jan 3, 2024

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Jan 2, 2024 •
edited
Loading

Switching from Metrics to Logical Files (for example)

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg January 2, 2024 13:52
@GordonSmith GordonSmith force-pushed the HPCC-31052-METRICS_LAYOUT_PERSIST branch from eb142c0 to a3e8fa4 Compare January 2, 2024 14:11
jeclrsg
jeclrsg requested changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith just a couple of small things - lint warning and a line of commented code. Also, I noticed the name & branch for this should've been HPCC-31053

esp/src/src-react/layouts/DockPanel.tsx Outdated
layoutChanged(dockPanel?.layout());
};
}, [dockPanel, layoutChanged]);
// selectAll(".flat li.lm-TabBar-tab.p-TabBar-tab").classed(useStyles().tab, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a line of commented out code here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed...

esp/src/src-react/index.tsx Outdated
@@ -38,6 +38,7 @@ needsRedirectV9().then(async redirected => {
}
});


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint warning

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed blank line.

@jeclrsg jeclrsg mentioned this pull request Jan 2, 2024
Merged
39 tasks
@GordonSmith GordonSmith force-pushed the HPCC-31052-METRICS_LAYOUT_PERSIST branch from a3e8fa4 to 99cfb53 Compare January 3, 2024 09:25
@GordonSmith GordonSmith requested a review from jeclrsg January 3, 2024 09:25
@GordonSmith GordonSmith force-pushed the HPCC-31052-METRICS_LAYOUT_PERSIST branch from 99cfb53 to ab32a59 Compare January 3, 2024 09:41
@GordonSmith GordonSmith changed the title HPCC-31052 Metrics layout fails to persist on top level change HPCC-31053 Metrics layout fails to persist on top level change Jan 3, 2024
@GordonSmith
Copy link
Member Author

@GordonSmith just a couple of small things - lint warning and a line of commented code. Also, I noticed the name & branch for this should've been HPCC-31053

Fixed the commit / jira issue number (good spot), rebased and fixed the lint / comment issues.

@GordonSmith GordonSmith force-pushed the HPCC-31052-METRICS_LAYOUT_PERSIST branch from ab32a59 to fae98e7 Compare January 3, 2024 09:47
@GordonSmith
HPCC-31053 Metrics layout fails to persist on top level change
71b8d11 
Switching from Metrics to Logical Files (for example)

Signed-off-by: Gordon Smith <[email protected]>
@GordonSmith GordonSmith force-pushed the HPCC-31052-METRICS_LAYOUT_PERSIST branch from fae98e7 to 71b8d11 Compare January 3, 2024 09:55
@GordonSmith GordonSmith merged commit ac50e39 into hpcc-systems:candidate-9.2.x Jan 3, 2024
50 checks passed
@GordonSmith GordonSmith deleted the HPCC-31052-METRICS_LAYOUT_PERSIST branch January 3, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonSmith @jeclrsg