Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-30974 Copying super files via fileservices/dfu does not track read/cost stats #18157

Merged
merged 1 commit into from
Jan 19, 2024
Merged

HPCC-30974 Copying super files via fileservices/dfu does not track read/cost stats #18157

merged 1 commit into from
Jan 19, 2024

Conversation

shamser
Copy link
Contributor

@shamser shamser commented Dec 19, 2023 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions GitHub Actions
Copy link

https://track.hpccsystems.com/browse/HPCC-30974
Jira updated

shamser
shamser commented Dec 19, 2023
View reviewed changes
dali/ft/filecopy.cpp Outdated
@@ -3384,25 +3385,9 @@ void FileSprayer::spray()
afterTransfer();

//If got here then we have succeeded
//(note: if we don't get here, file access costs will not be updated)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo:https://track.hpccsystems.com/browse/HPCC-31032

shamser
shamser commented Dec 19, 2023
View reviewed changes
dali/ft/filecopy.cpp Outdated
}
}

progressReport->setFileAccessCost(cost_type2money(totalCost));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improvement (read/write cost separately):https://track.hpccsystems.com/browse/HPCC-31032

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong JIRA ?

@shamser shamser requested a review from jakesmith December 19, 2023 13:09
@shamser shamser marked this pull request as draft December 19, 2023 14:30
@shamser shamser force-pushed the issue30974 branch 2 times, most recently from f5cb973 to 19c686e Compare December 20, 2023 10:31
jakesmith
jakesmith reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser - commenting only so not tagged for review.
Please refresh review status when ready for review

@shamser shamser force-pushed the issue30974 branch 2 times, most recently from ea45fe9 to 7af4035 Compare December 21, 2023 11:30
shamser
shamser commented Dec 21, 2023
View reviewed changes
dali/ft/filecopy.cpp
@@ -3384,25 +3384,9 @@ void FileSprayer::spray()
afterTransfer();

//If got here then we have succeeded
//Note: On failure, costs will not be updated. Future: would be useful to have a way to update costs on failure.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

future work: https://track.hpccsystems.com/browse/HPCC-31042

@shamser shamser force-pushed the issue30974 branch 2 times, most recently from 0caf1f2 to 24c9eef Compare December 21, 2023 11:40
@shamser shamser marked this pull request as ready for review December 21, 2023 16:05
@shamser shamser requested a review from jakesmith December 22, 2023 11:53
@shamser
Copy link
Contributor Author

shamser commented Jan 11, 2024

@jakesmith

jakesmith
jakesmith approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser - looks good, I can't see any issues.

I have opened a separate to revisit this, so that these stats are updated whilst the spray/copy is in-flight (not just when finished): https://track.hpccsystems.com/browse/HPCC-30965

@ghalliday
Copy link
Member

@shamser please rebase to avoid the clash with the merged cost_type change

@shamser shamser requested a review from jakesmith January 12, 2024 10:42
jakesmith
jakesmith approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser - looks good

@shamser
Copy link
Contributor Author

shamser commented Jan 12, 2024

@jakesmith The regression looks unrelated to this commit. It looks like a python related problem. @AttilaVamos Does this regression looks familiar?

@jakesmith
Copy link
Member

@jakesmith The regression looks unrelated to this commit. It looks like a python related problem. @AttilaVamos Does this regression looks familiar?

agree.
It may already be fixed elsewhere. @GordonSmith may know?

@GordonSmith
Copy link
Member

The regression failure is unrelated and should be resolved now...

@ghalliday ghalliday merged commit 969f6ef into hpcc-systems:candidate-9.4.x Jan 19, 2024
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakesmith jakesmith jakesmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shamser @ghalliday @jakesmith @GordonSmith