Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-30299 Update secrets in the background to avoid roxie stalls #18071

Merged
merged 1 commit into from
Jan 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions helm/hpcc/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2322,6 +2322,10 @@
"default": false,
"description": "Require SOAPCALL and HTTPCALL URLs are secrets or mapped to secrets"
},
"updateSecretsInBackground": {
"type": "boolean",
"description": "Preemptively update secrets that are active and about to expire in the background"
},
"expert": {
"description": "Custom internal options usually reserved for internal testing",
"type": "object"
Expand Down
3 changes: 3 additions & 0 deletions roxie/ccd/ccdmain.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -945,6 +945,8 @@ int CCD_API roxie_main(int argc, const char *argv[], const char * defaultYaml)
#endif

roxieMetrics.setown(createRoxieMetricsManager());
if (topology->getPropBool("@updateSecretsInBackground", !runOnce))
startSecretUpdateThread(0);

Owned<IPropertyTreeIterator> userMetrics = topology->getElements("./UserMetric");
ForEach(*userMetrics)
Expand Down Expand Up @@ -1686,6 +1688,7 @@ int CCD_API roxie_main(int argc, const char *argv[], const char * defaultYaml)
E->Release();
}

stopSecretUpdateThread();
roxieMetrics.clear();
#ifndef _CONTAINERIZED
stopPerformanceMonitor();
Expand Down
Loading
Loading