Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-30882 Add support for legacy (non-TLS) DFS access #18050

Merged
merged 1 commit into from
Nov 23, 2023
Merged

HPCC-30882 Add support for legacy (non-TLS) DFS access #18050

merged 1 commit into from
Nov 23, 2023

Conversation

jakesmith
Copy link
Member

@jakesmith jakesmith commented Nov 17, 2023 •
edited
Loading

via non-TLS ~remote and/or non-TLS ~foreign.

Allow the system to be configured with a separate non-TLS
DFS service and accompanying non-TLS directio.
This will allow a legacy bare-metal system, that dosn't support
secrets, to inter-operate with a suitably configured k8s hpcc
system via a dedicated DFS+directio service.

Signed-off-by: Jake Smith [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jakesmith jakesmith requested a review from ghalliday November 17, 2023 14:33
@jakesmith
Copy link
Member Author

@ghalliday - please review (2nd commit). NB: it is based on-top of #18049, which should be merged 1st, then this rebased.

@jakesmith jakesmith force-pushed the HPCC-30882-non-tls-dfs-directio branch from 2ada51a to 66e421a Compare November 20, 2023 16:08
@jakesmith jakesmith changed the title HPCC-30807 Add support for legacy (non-TLS) DFS access HPCC-30882 Add support for legacy (non-TLS) DFS access Nov 20, 2023
@jakesmith
Copy link
Member Author

@ghalliday - workflow runs rerunning because commit message mentioned wrong JIRA (now corrected)

@ghalliday
Copy link
Member

@jakesmith please can you rebase.

@jakesmith jakesmith force-pushed the HPCC-30882-non-tls-dfs-directio branch from 66e421a to b016d3f Compare November 22, 2023 10:28
@jakesmith
Copy link
Member Author

@ghalliday - rebased.

ghalliday
ghalliday approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One question on logging.

dali/base/dautils.cpp Outdated
throw makeStringExceptionV(0, "%s DFS service request made, but no %s directio service available", typeText, typeText);
}
StringBuffer epStr;
DBGLOG("Remap secure=%s to: %s", boolToStr(secure), dafileSrvNodeCopy->endpoint().getEndpointHostText(epStr).str());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakesmith will this generate excessive tracing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed/squashed

@jakesmith
HPCC-30882 Add support for legacy (non-TLS) DFS access
843d736 
via non-TLS ~remote and/or non-TLS ~foreign.

Allow the system to be configured with a separate non-TLS
DFS service and accompanying non-TLS directio.
This will allow a legacy bare-metal system, that dosn't support
secrets, to inter-operate with a suitably configured k8s hpcc
system via a dedicated DFS+directio service.

Signed-off-by: Jake Smith <[email protected]>
@jakesmith jakesmith force-pushed the HPCC-30882-non-tls-dfs-directio branch from b016d3f to 843d736 Compare November 23, 2023 16:39
@ghalliday ghalliday merged commit 8757da1 into hpcc-systems:candidate-9.4.x Nov 23, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakesmith @ghalliday