Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-30685 HPCC-30685 Report State always for Scheduled ECL WUs #18042

Merged
merged 1 commit into from
Nov 21, 2023
Merged

HPCC-30685 HPCC-30685 Report State always for Scheduled ECL WUs #18042

merged 1 commit into from
Nov 21, 2023

Conversation

wangkx
Copy link
Member

@wangkx wangkx commented Nov 16, 2023

Without this fix, the WU state is displayed inside the ECLWatch Event Scheduler tab only when a state filter is set inside the tab.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

HPCC-30685 HPCC-30685 Report State always for Scheduled ECL WUs
1be8e2d 
Without this fix, the WU state is displayed inside the ECLWatch
Event Scheduler tab only when a state filter is set inside the tab.

Signed-off-by: wangkx <[email protected]>
@github-actions GitHub Actions
Copy link

https://track.hpccsystems.com/browse/HPCC-30685
Jira updated

@wangkx wangkx requested a review from ghalliday November 16, 2023 21:51
@wangkx
Copy link
Member Author

wangkx commented Nov 16, 2023

@ghalliday I am targeting 8.10 because Sergio Fernandes asked (please see his comment in https://track.hpccsystems.com/browse/HPCC-30685). Please let me know if you want me change...

ghalliday
ghalliday approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ghalliday ghalliday changed the base branch from candidate-8.10.x to candidate-8.12.x November 17, 2023 15:02
@ghalliday
Copy link
Member

I have re-targeted to 8.12.x because 8.10.x is no longer actively supported

@wangkx
Copy link
Member Author

wangkx commented Nov 17, 2023

The 8.12.x is ok for me. This PR can be merged if no issue is found in the smoketest.

@ghalliday ghalliday closed this Nov 17, 2023
@ghalliday ghalliday reopened this Nov 17, 2023
@github-actions GitHub Actions
Copy link

https://track.hpccsystems.com/browse/HPCC-30685
This pull request is already registered

@ghalliday ghalliday changed the base branch from candidate-8.12.x to candidate-9.2.x November 21, 2023 13:02
@ghalliday ghalliday merged commit 6240f56 into hpcc-systems:candidate-9.2.x Nov 21, 2023
69 of 74 checks passed
@FernSe01
Copy link

As per email dialogue with @ghalliday, also attached
RE HPCC 8.10 bugs found by Quod (Brazil bureau).pdf), can we target next 8.10 build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangkx @ghalliday @FernSe01