Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-30735 Check regular expressions are valid at compile time #17995

Merged
merged 1 commit into from
Nov 9, 2023
Merged

HPCC-30735 Check regular expressions are valid at compile time #17995

merged 1 commit into from
Nov 9, 2023

Conversation

ghalliday
Copy link
Member

@ghalliday ghalliday commented Nov 3, 2023 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@ghalliday ghalliday requested a review from shamser November 3, 2023 10:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

https://track.hpccsystems.com/browse/HPCC-30735
Jira updated

@ghalliday
Copy link
Member Author

Caught one pre-existing example in ecl/regress/jholt10.ecl.

shamser
shamser requested changes Nov 3, 2023
View reviewed changes
ecl/regress/badregexfind.ecl Outdated
limitations under the License.
############################################################################## */

string searchString := '' : stored('searchSting');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: stored('searchString')

ecl/regress/badregexfind2.ecl Outdated
limitations under the License.
############################################################################## */

string searchString := '' : stored('searchSting');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: stored('searchString')

ecl/hqlcpp/hqlhtcpp.cpp
//Most regexes will have been checked in the parser, but not if it is the result of a constant fold.
//Check again because an error thrown in a static constructor of a dynamically loaded dll can cause
//the process to abort HPCC-30735
Owned<IException> e = checkRegexSyntax(pattern);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is checked here, is it necessary to check it in the parser too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because in the parser it will report an error that directly links to the line with the problem. Here it is unlikely to have any indication where the problem is.

@ghalliday ghalliday requested a review from shamser November 7, 2023 10:13
@ghalliday
Copy link
Member Author

Fixed and squashed.

@ghalliday ghalliday merged commit 7fff663 into hpcc-systems:candidate-9.4.x Nov 9, 2023
29 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamser shamser shamser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghalliday @shamser