Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-30606 Fix "significant skew in records warning" #17961

Merged
merged 1 commit into from
Nov 9, 2023
Merged

HPCC-30606 Fix "significant skew in records warning" #17961

merged 1 commit into from
Nov 9, 2023

Conversation

shamser
Copy link
Contributor

@shamser shamser commented Oct 26, 2023 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@shamser shamser requested a review from ghalliday October 26, 2023 15:01
@github-actions
Copy link

https://track.hpccsystems.com/browse/HPCC-30606
Jira updated

ghalliday
ghalliday reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser looks good. A couple of comments.

common/wuanalysis/anarule.cpp Outdated
else
{
bool fileSkew = false;
if (stat == StTimeDiskWriteIO)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are 3 cases worth separating.

i) No skew in size written => Significant skew in IO performance
ii) skew in size written but no skew in record counts => Significant skew in record sizes
iii) skew in size written and record counts => Significant skew in number of record

Skew in size

common/wuanalysis/anarule.cpp Outdated
{
IWuEdge *inputEdge;
unsigned i=0;
while (!fileSkew && (inputEdge=activity.queryInput(i++)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will only ever be one input, so this could be simplified.

common/wuanalysis/anarule.cpp Outdated
}
if (stat == StTimeDiskReadIO)
{
IWuEdge *outputEdge;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will only ever be one output, so this could be simplified.

@shamser shamser requested a review from ghalliday November 1, 2023 10:25
ghalliday
ghalliday reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser one issue, otherwise looks good.

common/wuanalysis/anarule.cpp Outdated
IWuEdge *wuEdge = nullptr;
if ((stat==StTimeDiskWriteIO) || (actkind==TAKspillwrite))
{
if (activity.getStatRaw(StSizeDiskWrite)>options.queryOption(watOptSkewThreshold))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing the wrong stat. Needs to be getStatRaw(StSizeDiskWrite, StSkewMax). Same for the code below.

common/wuanalysis/anarule.cpp
IWuEdge *wuEdge = activity.queryOutput(0);
}
if (wuEdge && wuEdge->getStatRaw(StNumRowsProcessed, StSkewMax)>options.queryOption(watOptSkewThreshold))
numRowsSkew = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is slightly tricky for a disk read, because it may be filtered, but probably better than not taking it into account.

@shamser shamser requested a review from ghalliday November 6, 2023 09:38
ghalliday
ghalliday approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser looks good, please squash

@shamser shamser requested a review from ghalliday November 9, 2023 11:53
@ghalliday ghalliday merged commit 6f5e9a8 into hpcc-systems:candidate-9.4.x Nov 9, 2023
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shamser @ghalliday