Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-30278 ECL Watch v9 fix clear datetime-local filter fields #17926

Merged
merged 1 commit into from
Oct 27, 2023
Merged

HPCC-30278 ECL Watch v9 fix clear datetime-local filter fields #17926

merged 1 commit into from
Oct 27, 2023

Conversation

jeclrsg
Copy link
Contributor

@jeclrsg jeclrsg commented Oct 19, 2023

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jeclrsg jeclrsg requested a review from GordonSmith October 19, 2023 19:27
@github-actions
Copy link

https://track.hpccsystems.com/browse/HPCC-30278
Jira updated

GordonSmith
GordonSmith requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

esp/src/src-react/components/forms/Fields.tsx
@@ -902,6 +902,7 @@ export function createInputs(fields: Fields, onChange?: (id: string, newValue: a
label: field.label,
field: <input
key={fieldID}
id={fieldID}
type="datetime-local"
name={fieldID}
defaultValue={field.value}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would changing "defaultValue" here to "value" have fixed the issue also?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did not. Using "value" instead, the filter would have updated with the selected datetime on submit, but the input wouldn't display it.

GordonSmith
GordonSmith requested changes Oct 26, 2023
View reviewed changes
esp/src/src-react/components/forms/Fields.tsx Outdated
@@ -910,6 +911,10 @@ export function createInputs(fields: Fields, onChange?: (id: string, newValue: a
}}
/>
});
const el = document.querySelector(`#${fieldID}`);
Copy link
Member

@GordonSmith GordonSmith Oct 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeclrsg - Do you think we need to make this ID a little more unique? Or do the query at the form level?

@jeclrsg jeclrsg force-pushed the hpcc-30278-clear-datetime-local-fields branch from a62be7f to f61e3af Compare October 26, 2023 14:14
@GordonSmith GordonSmith merged commit 4c39442 into hpcc-systems:candidate-9.2.x Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GordonSmith GordonSmith GordonSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeclrsg @GordonSmith