Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-29674 LogAccess support for pod column type #17913

Merged
merged 1 commit into from
Oct 26, 2023
Merged

HPCC-29674 LogAccess support for pod column type #17913

merged 1 commit into from
Oct 26, 2023

Conversation

rpastrana
Copy link
Member

@rpastrana rpastrana commented Oct 18, 2023 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@rpastrana rpastrana force-pushed the HPCC-29674-LogAccess-support-for-Pod-column-type branch from 57caa2d to af5aa8f Compare October 18, 2023 13:12
@rpastrana
Copy link
Member Author

rpastrana commented Oct 18, 2023 •
edited
Loading

image

image

@rpastrana
Copy link
Member Author

image

jakesmith
jakesmith reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpastrana - All looks reasonable, 1 minor comment re. log level.

Will revisit to approve when base PR is merged.
Please tag me here when that is merged and this PR is rebased.

system/logaccess/Azure/LogAnalytics/CurlClient/AzureLogAnalyticsCurlClient.cpp
queryIndex = m_podIndexSearchPattern.str();
}

DBGLOG("%s: Searching log entries by Pod: '%s'", COMPONENT_NAME, queryValue.str() );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not specific to this new column, but we should probably avoid these log lines by default, i.e. set them at a higher logging level.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... I agree these types of messages are helpful for debugging ergo the DBGLOG seems appropriate, the problem from my perspective is the default log level for our deployments is 80 which is equivalent to debug, I've been advocating for a lower default log level for a long time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree - but would require a more comprehensive review of all DBGLOG's I suspect before we commit to turning them off by default.

Is there a JIRA this topic?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, in fact we have too many jiras related to this topic:

HPCC-22646 Revisit logging levels
HPCC-18399 Use jlog logging more consistently
HPCC-24433 Log levels above max threshold should be reevaluated
HPCC-30629 Clean up roxie logs
HPCC-26886 Consider adding detail level to the log output
HPCC-22650 Switch to using the tracing levels in logging

@rpastrana
HPCC-29674 LogAccess Pod data support
92f231b 
- Introduces PodName log column type
- Adds filter support per PodName
- Includes PodName in ALA default column requests
- Adds Pod logMap to ALAv2 values file
- Adds WsLogAccess byPod definitions

Signed-off-by: Rodrigo Pastrana <[email protected]>
@rpastrana rpastrana force-pushed the HPCC-29674-LogAccess-support-for-Pod-column-type branch from af5aa8f to 92f231b Compare October 25, 2023 18:41
@rpastrana rpastrana requested a review from jakesmith October 25, 2023 18:42
@rpastrana
Copy link
Member Author

@jakesmith rebased.

@rpastrana rpastrana changed the title Hpcc 29674 log access support for pod column type HPCC-29674 LogAccess support for pod column type Oct 25, 2023
@rpastrana
Copy link
Member Author

@jeclrsg does this provide everything we need for https://track.hpccsystems.com/browse/HPCC-30568?

jeclrsg
jeclrsg approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpastrana I think so. Looks good to me.

jakesmith
jakesmith approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpastrana - looks good.

@ghalliday ghalliday merged commit 2a8bb4b into hpcc-systems:candidate-9.4.x Oct 26, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg approved these changes

@jakesmith jakesmith jakesmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rpastrana @jakesmith @jeclrsg @ghalliday