-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-30277 Fix failed docker builds on JFrog #17908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Output with dummy.io looks like this:
tags: dummy.io/hpccpl-docker-local/hpcc-platform/ubuntu-22.04/platform-core-ln:internal_hpcc-30277
dummy.io/hpccpl-docker-local/hpcc-platform/ubuntu-22.04/platform-build-ln:HPCC-30277..x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gfortil - please see comments.
Signed-off-by: Godji Fortil <[email protected]> HPCC-30227 Fix failed Docker builds on JFrog Signed-off-by: Godji Fortil <[email protected]> HPCC-30227 Fix failed Docker builds on JFrog Signed-off-by: Godji Fortil <[email protected]> Fix failed docker builds on JFrog Signed-off-by: Godji Fortil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@@ -330,8 +330,7 @@ jobs: | |||
build-args: | | |||
PKG_FILE=${{ steps.ln-container.outputs.k8s_pkg_file }} | |||
tags: | | |||
${{ secrets.JFROG_REGISTRY || 'dummy.io' }}/ln/platform-core-${{ matrix.os }}:${{ needs.preamble.outputs.internal_tag }} | |||
${{ secrets.JFROG_REGISTRY || 'dummy.io' }}/ln/platform-core-${{ matrix.os }}:${{ needs.preamble.outputs.candidate_base_branch }} | |||
${{ secrets.JFROG_REGISTRY || 'dummy.io' }}/hpccpl-docker-local/hpcc-platform/${{ matrix.os }}/platform-core-ln:${{ needs.preamble.outputs.internal_tag }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gfortil - I think prior to this change the action failed to push because it was trying to push to the directory 'ln':
ERROR: failed to solve: failed to push ***/ln/platform-core-ubuntu-22.04:internal_9.4.4-rc1: unexpected status from POST request to https://***/v2/ln/platform-core-ubuntu-22.04/blobs/uploads/: 404 Not Found
Error: buildx failed with: ERROR: failed to solve: failed to push ***/ln/platform-core-ubuntu-22.04:internal_9.4.4-rc1: unexpected status from POST request to https://***/v2/ln/platform-core-ubuntu-22.04/blobs/uploads/: 404 Not Found
with this PR change, it will now be trying to push the image inside directory 'hpccpl-docker-local/hpcc-platform/ubuntu-22.04' , is that directory guaranteed to exist, and this new push path succeed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakesmith the hpccpl-docker-local at the beginning is the key to making it work properly. I tested the path Godji supplied earlier this evening and confirmed that it does work. I'll pass you the link on teams.
20f02aa
into
hpcc-systems:candidate-9.2.x
Type of change:
Checklist:
Smoketest:
Testing: